Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include network padding in application padding #60

Open
jfallows opened this issue May 15, 2020 · 0 comments · May be fixed by #72
Open

Include network padding in application padding #60

jfallows opened this issue May 15, 2020 · 0 comments · May be fixed by #72
Assignees
@dknoma
Labels
bug Something isn't working

Comments

@jfallows
Copy link
Collaborator

Looks like we are currently assuming that the network padding is 0.

See MqttServerFactory.java:2567

doWindow(application, routeId, replyId, traceId, authorization,
    encodeBudgetId, replyCredit, PUBLISH_FRAMING);

Seems like that should be encodePadding + PUBLISH_FRAMING instead.
@jfallows jfallows added the bug Something isn't working label May 15, 2020
@dknoma dknoma linked a pull request Aug 18, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dknoma dknoma

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include network padding in application padding dknoma/nukleus-mqtt.java
2 participants
@jfallows @dknoma