Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safer null check for MessagePanel #41

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

safer null check for MessagePanel #41

wants to merge 1 commit into from

Conversation

Thaina
Copy link
Contributor

@Thaina Thaina commented Jun 17, 2024

Description

Sometimes we want to use webViewPanel without MessagePanel. But there if no check and it would throw error

Changes

Added

  • Check messagePanel with if

Updated

  • Use if check for some other unity object, because null propagation is not fully cover unity nullability for destroy object

How to Test

  • Use webview without setting a message panel

Checklist

  • [ x ] Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@Thaina Thaina requested a review from a team as a code owner June 17, 2024 14:35
@Thaina Thaina mentioned this pull request Jun 28, 2024
Open
@Thaina
Copy link
Contributor Author

Thaina commented Jun 28, 2024

Made issue #42

@Thaina Thaina closed this Jun 28, 2024
@Thaina Thaina reopened this Jun 28, 2024
@Thaina
Copy link
Contributor Author

Thaina commented Jun 29, 2024

@HarrisonHough are there any reason we require messagePanel ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Thaina