Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(colors): mark avatar's equipped colors as selected #327

Merged
merged 5 commits into from
Dec 16, 2024
Merged

feat(colors): mark avatar's equipped colors as selected #327

merged 5 commits into from
Dec 16, 2024

Conversation

sander-rpm
Copy link

@sander-rpm sander-rpm commented Dec 13, 2024 •
edited by jira bot
Loading

SRV-1555

Description

How to Test

  • Open the AvatarCreatorWizard scene.
  • Create a new avatar using the template.
  • In the editor, navigate to the skin, eyebrow, hair, or beard category.
  • Verify that the displayed color matches what the avatar is currently wearing.
Screen.Recording.2024-12-13.at.16.13.29.mov

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@sander-rpm sander-rpm requested a review from a team as a code owner December 13, 2024 14:58
@sander-rpm sander-rpm marked this pull request as draft December 13, 2024 14:58
@sander-rpm sander-rpm changed the title Feature/srv 1555 feat(colors): mark avatar's equipped colors as selected Dec 13, 2024
@sander-rpm sander-rpm marked this pull request as ready for review December 13, 2024 15:17
Kristokarp
Kristokarp approved these changes Dec 16, 2024
View reviewed changes
Copy link

@Kristokarp Kristokarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe Sarge or Harrisson could take a look as well

@HarrisonHough HarrisonHough changed the base branch from main to develop December 16, 2024 08:18
HarrisonHough
HarrisonHough requested changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is 1 compile error that needs fixing (see comments)
Other than that just a minor suggestion about namespace usage

...atarCreatorSamples/AvatarCreatorWizard/Scripts/UI/SelectionScreens/AvatarCreatorSelection.cs Outdated Show resolved Hide resolved
Samples~/AvatarCreatorSamples/AvatarCreatorWizard/Scripts/Utils/AssetTypeHelper.cs Outdated Show resolved Hide resolved
HarrisonHough
HarrisonHough approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Nice work!

@sander-rpm sander-rpm merged commit ebfa6ed into develop Dec 16, 2024
@sander-rpm sander-rpm deleted the feature/SRV-1555 branch December 16, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kristokarp Kristokarp Kristokarp approved these changes

@HarrisonHough HarrisonHough HarrisonHough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avatar creator has wrong skin, hair color selected.
3 participants
@sander-rpm @HarrisonHough @Kristokarp