Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avatar creator has wrong skin, hair color selected. #325

Open
Archi97 opened this issue Nov 30, 2024 · 0 comments · Fixed by #327
Open

Avatar creator has wrong skin, hair color selected. #325

Archi97 opened this issue Nov 30, 2024 · 0 comments · Fixed by #327
Labels
bug Something isn't working

Comments

@Archi97
Copy link

Archi97 commented Nov 30, 2024

In the Sample of Avatar Creator (scene - AvatarCreatorWizard) when the avatar is loaded the skin and hair color are set to the 1st one:
This comes from the code in AssetButtonCreator, line 88.

But this is wrong as the 1st color is not the correct one. I have looked into the other item(Eye Color) to see how is it set, and saw that it is actually an asset that gets created at the beginning, and colors are not counted as assets.
How can we know the index of color and set it correctly?

Steps to reproduce the behavior:

  1. Create Unity Project
  2. Import RPM SDK, set the domain and API token and sample 'avatar creator',
  3. run scene AvatarCreatorWizard
  4. Create a new avatar from the template, and select the prelast avatar with green hair.
  5. in the editor go to the hair style tab, and check the color - it is ~brown

Expected behavior
Green Color must be selected.

image

Desktop (please complete the following information):

  • Ready Player Me Core version 7.1.1, 7.3.1
  • Ready Player Me WebView version - Nan
  • glTFast version 6.0.1
  • Unity Editor version 2022.3.50f1
  • Render Pipeline and version Built In
  • Operating System Windows
  • Platform: Windows, Android, IOS
@Archi97 Archi97 added the bug Something isn't working label Nov 30, 2024
@sander-rpm sander-rpm mentioned this issue Dec 13, 2024
Merged
3 tasks
sander-rpm added a commit that referenced this issue Dec 16, 2024
@sander-rpm @HarrisonHough
feat(colors): mark avatar's equipped colors as selected (#327)
ebfa6ed 
## [SRV-1555](https://ready-player-me.atlassian.net/browse/SRV-1555)

## Description

- Fixes #325.
- These changes ensure that equipped colors are now taken into account
when loading an avatar, instead of defaulting to the first color.

## How to Test

- Open the AvatarCreatorWizard scene.
- Create a new avatar using the template.
- In the editor, navigate to the skin, eyebrow, hair, or beard category.
- Verify that the displayed color matches what the avatar is currently
wearing.


https://github.com/user-attachments/assets/0a8c7992-ed94-4ece-8b66-9cf7bbbf2962

[SRV-1555]:
https://ready-player-me.atlassian.net/browse/SRV-1555?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: Harrison Hough <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(colors): mark avatar's equipped colors as selected readyplayerme/rpm-unity-sdk-core
1 participant
@Archi97