Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add note about VCS SSO in the manual import guide #9426

Open
stsewd opened this issue Jul 12, 2022 · 4 comments
Open

Docs: add note about VCS SSO in the manual import guide #9426

stsewd opened this issue Jul 12, 2022 · 4 comments
Labels
Improvement Minor improvement to code Needed: documentation Documentation is required

Comments

@stsewd
Copy link
Member

stsewd commented Jul 12, 2022

Our guide at https://docs.readthedocs.io/en/stable/guides/importing-private-repositories.html should warn users that if they have the VCS SSO integration enabled, they can't import projects manually, we could also add this warning in the import page itself, and block the action.

@stsewd stsewd added Needed: documentation Documentation is required Improvement Minor improvement to code labels Aug 18, 2022
@humitos
Copy link
Member

humitos commented Feb 21, 2024

@agjohnson pinging you here since you have been working on this UX pattern on the new templates. Maybe you already solved this problem there and we can close the issue.

@agjohnson
Copy link
Contributor

This will be addressed in the application with: readthedocs/ext-theme#274

This PR is mentioning docs, which I do think should still be updated to cover these types of caveats more. The application UX is the primary place the users should encounter this information, but it's helpful to have supporting information in our docs too.

@humitos
Copy link
Member

humitos commented Sep 10, 2024

Related with the changes done by

I'm adding this issue to Q4 since we have been working on improving the on boarding experience.

@humitos
Copy link
Member

humitos commented Nov 4, 2024

warn users that if they have the VCS SSO integration enabled, they can't import projects manually

The new dashboard allows this. It looks like this:

Image

I suppose we should detect in that form the project is being manually imported and remove VCS SSO organizations or fail the validation form when selecting that organization.

This issue could be combined with readthedocs/ext-theme#468 where we want to use a more richer UI element to display extra context. There, we could mention this limitation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Needed: documentation Documentation is required
Projects
Status: Planned
Development

No branches or pull requests

3 participants