Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project: error on wizard #477

Open
humitos opened this issue Sep 9, 2024 · 11 comments · May be fixed by readthedocs/readthedocs.org#11795
Open

Add project: error on wizard #477

humitos opened this issue Sep 9, 2024 · 11 comments · May be fixed by readthedocs/readthedocs.org#11795
Assignees
Labels
Accepted Accepted issue on our roadmap Bug A bug

Comments

@humitos
Copy link
Member

humitos commented Sep 9, 2024

I added a project automatically using this GitLab project https://gitlab.com/humitos/rtd-project-a and got a 500.

Sentry issue: https://read-the-docs.sentry.io/issues/5792086719/?project=148442&query=is%3Aunresolved+%21message%3A%22%21message%3A%22%21message%3A%22SystemExit%22+%21message%3A%22frame-ancestors%22&referrer=issue-stream&statsPeriod=14d&stream_index=0

Note that it works on the old dashboard without issues.

@humitos humitos added Bug A bug Accepted Accepted issue on our roadmap labels Sep 9, 2024
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Sep 9, 2024
@humitos humitos self-assigned this Sep 10, 2024
@humitos
Copy link
Member Author

humitos commented Sep 18, 2024

I tried reproducing this on community and commercial, but I wasn't able to replicate it.

@humitos
Copy link
Member Author

humitos commented Sep 18, 2024

I'm not able to reproduce this issue anymore.

@humitos humitos closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in 📍Roadmap Sep 18, 2024
@humitos
Copy link
Member Author

humitos commented Sep 18, 2024

Meh, it keeps happening because Sentry still reports it, but I'm unable to reproduce it 🤷🏼

It happens at https://readthedocs.org/dashboard/import/manual/

@humitos humitos reopened this Sep 18, 2024
@github-project-automation github-project-automation bot moved this from Done to In progress in 📍Roadmap Sep 18, 2024
@humitos
Copy link
Member Author

humitos commented Sep 18, 2024

I guess this is because of some weird usage of the form, maybe because spammers...

@agjohnson
Copy link
Contributor

Is this different from readthedocs/readthedocs-ops#1539 ?

  • readthedocs/readthedocs-ops#1539

@agjohnson agjohnson added the Needed: replication Bug replication is required label Sep 24, 2024
@humitos
Copy link
Member Author

humitos commented Sep 25, 2024

I'm not able to reproduce this issue anymore. I've tried adding a GitLab repository on .org and .com.

@agjohnson
Copy link
Contributor

Note: this could be going back in the form at config step or something, the config key is missing from the form wizard list of forms.

@ericholscher
Copy link
Member

We think this is a bot doing something hacky, probably not a real issue.

@humitos
Copy link
Member Author

humitos commented Oct 30, 2024

I'm going to close it for now. We can come back if we start getting user reports.

@humitos humitos closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in 📍Roadmap Oct 30, 2024
@humitos
Copy link
Member Author

humitos commented Nov 25, 2024

I got a support request from a user about this: https://app.frontapp.com/open/cnv_ori78av?key=7bu4nReUCopK8_sMwONvi_U05Aw-HHLa

and I was able to reproduce it by following these steps:

  1. Go to https://app.readthedocs.org/dashboard/import/manual/
  2. Repo name: whatever
  3. Repository URL: https://github.com/Mahendra-TitanEd/lms-documentation.git
  4. Default branch: vic-documentation
  5. Language: English
  6. Click Next
  7. Click This file exists
  8. A 500 error is shown

This is the entry in Sentry: https://read-the-docs.sentry.io/issues/5792086719/events/7a29f1ecc6874b4da1a960dfc364390c/?project=148442&query=is%3Aunresolved%20%21message%3A%22%21message%3A%22%21message%3A%22SystemExit%22%20%21message%3A%22frame-ancestors%22&referrer=next-event&statsPeriod=14d&stream_index=0

After testing it, I tried to reproduce it again and I wasn't able to. I'm pretty confused about what's going on here 🤷🏼. @readthedocs/core any of you is able to reproduce it?

@humitos humitos reopened this Nov 25, 2024
@stsewd
Copy link
Member

stsewd commented Nov 25, 2024

This is because form_list is a class attribute, once it's modified by one request, it will be changed for all subsequent requests (requests to the same server anyway). I guess django restarts after a 500, that's why we don't see this more often, you can probably replicate this by importing a project that hits that code twice.

humitos added a commit to readthedocs/readthedocs.org that referenced this issue Nov 25, 2024
@humitos humitos removed the Needed: replication Bug replication is required label Nov 25, 2024
@humitos humitos moved this from Done to Needs review in 📍Roadmap Nov 25, 2024
humitos added a commit to readthedocs/readthedocs.org that referenced this issue Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
Status: Needs review
Development

Successfully merging a pull request may close this issue.

4 participants