Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modals are missing a cancel/close button #510

Open
stsewd opened this issue Oct 28, 2024 · 0 comments · May be fixed by #519
Open

Modals are missing a cancel/close button #510

stsewd opened this issue Oct 28, 2024 · 0 comments · May be fixed by #519

Comments

@stsewd
Copy link
Member

stsewd commented Oct 28, 2024

When there is a destructive option, we are showing a modal, which is great. But we aren't showing a "cancel" or "close" button, so there is no much information about how to close the modal. Pressing escape or clicking outside the modal closes the modal, but that may not be obvious to everyone.

Screenshot 2024-10-28 at 10-50-58 test-builds-2 - Redirects - Read the Docs

@stsewd stsewd linked a pull request Nov 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant