Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial pass of .net bugfixes #460

Open
Dashron opened this issue May 26, 2022 · 0 comments
Open

initial pass of .net bugfixes #460

Dashron opened this issue May 26, 2022 · 0 comments
Labels
bug Something isn't working dotnet Issues related to our .NET SDK

Comments

@Dashron
Copy link
Contributor

Dashron commented May 26, 2022

If you don’t provide a label or email in the grouping function the middleware dies silently.

E.g.

app.Use(async (context, next) =>
{
    context.Items["apiKey"] = context.Request.Headers["key"];
    await next(); //GETTING a null reference exception here
});

We would like…

  1. A good way to get to that null reference exception. Our client knew how to get it, but I didn't! We should make any necessary changes and document how to see errors.
  2. Only apiKey is required, so there shouldn’t be an error at all if we leave out the other fields.

Censored params are removed not censored

Other libs have [redacted-{character-count}], .net is just removing the value entirely

Support .net framework

.net framework is different than .net core. framework seems to be legacy from what I can tell

@Dashron Dashron added the dotnet Issues related to our .NET SDK label May 26, 2022
@erunion erunion added the bug Something isn't working label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dotnet Issues related to our .NET SDK
Projects
None yet
Development

No branches or pull requests

2 participants