Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken NPM package dependencies due to unstable / non-fixed references to GitHub repositories (branch HEADs) #757

Closed
danielweck opened this issue Feb 9, 2022 · 8 comments

Comments

@danielweck
Copy link
Member

danielweck commented Feb 9, 2022

readium-cfi-js is not affected:

https://github.com/readium/readium-shared-js/blob/15412a0b8b9c98d060885fa98584a8205dce6a8d/package.json#L44-L46

==>

https://github.com/readium/readium-cfi-js/blob/0.31.0/package.json#L48-L68

https://github.com/readium/readium-shared-js/blob/15412a0b8b9c98d060885fa98584a8205dce6a8d/package-lock.json#L3069-L3071

"readium-cfi-js": {
      "version": "github:readium/readium-cfi-js#ad82c14c7c9d846e073a8010471fdd1f261c76a4",
      "from": "github:readium/readium-cfi-js#v0.31.0-alpha",
@danielweck
Copy link
Member Author

readium-shared-js is affected:

https://github.com/readium/readium-shared-js/blob/15412a0b8b9c98d060885fa98584a8205dce6a8d/package.json#L44-L77

  • "amdclean": "github:JCCR/amdclean#master"
  • "css-element-queries": "github:danielweck/css-element-queries#master"
  • "cssom": "github:danielweck/CSSOM#master"
  • "domReady": "github:requirejs/domReady#master"
  • "http-server": "github:danielweck/http-server#master"
  • "jquery-sizes": "github:JCCR/jquery-sizes#master"
  • "urijs": "github:danielweck/URI.js#master"

@danielweck
Copy link
Member Author

readium-js is affected:

https://github.com/readium/readium-js/blob/b2c65bf3dd3b47ec716d328479a3c8af51fde0d2/package.json#L47-L59

  • "http-server": "github:danielweck/http-server#master"
  • "zip-js": "github:danielweck/zip.js#master"

@danielweck
Copy link
Member Author

danielweck commented Feb 9, 2022

readium-js-viewer is affected:

"dependencies": {
"concurrently": "^3.6.0",
"npm-run-all": "^4.1.3",
"opener": "^1.4.3",
"http-server": "github:danielweck/http-server#master"
},
"devDependencies": {
"keymaster": "github:danielweck/keymaster#master",
"jath": "github:danielweck/jath#master",
"mathjax-single-file": "github:danielweck/MathJax-single-file#master",
"bootstrap": "3.x",
"bootstrap-accessibility-plugin": "github:paypal/bootstrap-accessibility-plugin#main",
"hammerjs": "^2.0.8",
"jquery-hammerjs": "^2.0.0",
"screenfull": "^3.3.2",
"JSON2": "^0.1.0",
"hogan": "^1.0.2",
"requirejs-hogan-plugin": "^0.3.1",
"remotestoragejs": "^1.0.3",
"spin.js": "2.x",
"gift": "^0.10.1",
"clean-css-cli": "^4.1.10",
"uglify-js": "^3.4.1",
"mocha": "^5.2.0",
"wd": "^1.9.0",
"phantomjs-prebuilt": "^2.1.16",
"grunt-selenium-webdriver": "github:levexis/grunt-selenium-webdriver#master",
"crx": "^3.2.1",
"chai": "3.x",
"chai-as-promised": "^7.1.1",
"github": "12.x",
"hogan.js": "^3.0.2",
"httpreq": "^0.4.24",
"xml2js": "^0.4.19",
"decompress-zip": "^0.3.1"
},

  • "http-server": "github:danielweck/http-server#master"
  • "keymaster": "github:danielweck/keymaster#master"
  • "jath": "github:danielweck/jath#master"
  • "mathjax-single-file": "github:danielweck/MathJax-single-file#master"
  • "bootstrap-accessibility-plugin": "github:paypal/bootstrap-accessibility-plugin#main"
  • "grunt-selenium-webdriver": "github:levexis/grunt-selenium-webdriver#master"

@danielweck
Copy link
Member Author

Plan of action: restore sanity in master and develop branch.
First step: the package-lock.json files dictate the actual versions that are supported by each repository at this point in time.

https://github.com/readium/readium-shared-js/blob/15412a0b8b9c98d060885fa98584a8205dce6a8d/package-lock.json#L3069-L3071

"readium-cfi-js": {
      "version": "github:readium/readium-cfi-js#ad82c14c7c9d846e073a8010471fdd1f261c76a4",
      "from": "github:readium/readium-cfi-js#v0.31.0-alpha",

https://github.com/readium/readium-js/blob/b2c65bf3dd3b47ec716d328479a3c8af51fde0d2/package-lock.json#L315-L317

"http-server": {
      "version": "github:danielweck/http-server#70902a29413aa922c1b3484a1c4a04ed58894dde",
      "from": "github:danielweck/http-server#master",

https://github.com/readium/readium-js/blob/b2c65bf3dd3b47ec716d328479a3c8af51fde0d2/package-lock.json#L755-L757

"zip-js": {
      "version": "github:danielweck/zip.js#f71eda6df5a85aad2b96c8718c33b97e13b684ee",
      "from": "github:danielweck/zip.js#master",

"http-server": {
"version": "github:danielweck/http-server#70902a29413aa922c1b3484a1c4a04ed58894dde",
"from": "github:danielweck/http-server#master",

"http-server": {
      "version": "github:danielweck/http-server#70902a29413aa922c1b3484a1c4a04ed58894dde",
      "from": "github:danielweck/http-server#master",

"jath": {
"version": "github:danielweck/jath#ed637b98dda03f763346b044b33f17f7bf6ab64c",
"from": "github:danielweck/jath#master",

"jath": {
      "version": "github:danielweck/jath#ed637b98dda03f763346b044b33f17f7bf6ab64c",
      "from": "github:danielweck/jath#master",

"keymaster": {
"version": "github:danielweck/keymaster#c154e408b0ff18f122e8e84e38ab320e20eb8102",
"from": "github:danielweck/keymaster#master",

"keymaster": {
      "version": "github:danielweck/keymaster#c154e408b0ff18f122e8e84e38ab320e20eb8102",
      "from": "github:danielweck/keymaster#master",

"mathjax-single-file": {
"version": "github:danielweck/MathJax-single-file#e5b8b188f59595af8cb0cef4bfd855ec91b18571",
"from": "github:danielweck/MathJax-single-file#master",

"mathjax-single-file": {
      "version": "github:danielweck/MathJax-single-file#e5b8b188f59595af8cb0cef4bfd855ec91b18571",
      "from": "github:danielweck/MathJax-single-file#master",

@danielweck
Copy link
Member Author

Other third parties:

"bootstrap-accessibility-plugin": {
"version": "github:paypal/bootstrap-accessibility-plugin#fbbf870eafc1ee5d4547fabbeea71778ddbe2166",
"from": "github:paypal/bootstrap-accessibility-plugin#main",

    "bootstrap-accessibility-plugin": {
      "version": "github:paypal/bootstrap-accessibility-plugin#fbbf870eafc1ee5d4547fabbeea71778ddbe2166",
      "from": "github:paypal/bootstrap-accessibility-plugin#main",

"grunt-selenium-webdriver": {
"version": "github:levexis/grunt-selenium-webdriver#e9f63af80c8e6738b00812370c6f1ba13c5dc817",
"from": "github:levexis/grunt-selenium-webdriver#master",

"grunt-selenium-webdriver": {
      "version": "github:levexis/grunt-selenium-webdriver#e9f63af80c8e6738b00812370c6f1ba13c5dc817",
      "from": "github:levexis/grunt-selenium-webdriver#master",

https://github.com/readium/readium-shared-js/blob/15412a0b8b9c98d060885fa98584a8205dce6a8d/package-lock.json#L52-L54

"amdclean": {
      "version": "github:JCCR/amdclean#e4ffc3d8a634110ec7ce7e2474e859c021afe5fc",
      "from": "github:JCCR/amdclean#master",

https://github.com/readium/readium-shared-js/blob/15412a0b8b9c98d060885fa98584a8205dce6a8d/package-lock.json#L969-L971

"domReady": {
      "version": "github:requirejs/domReady#d85bdc38a6df868ead52ab3e80715aaf60e68765",
      "from": "github:requirejs/domReady#master",

https://github.com/readium/readium-shared-js/blob/15412a0b8b9c98d060885fa98584a8205dce6a8d/package-lock.json#L2123-L2125

"jquery-sizes": {
      "version": "github:JCCR/jquery-sizes#d26d2510d069f84a64052c443a06b8534c5e9d0e",
      "from": "github:JCCR/jquery-sizes#master",

@danielweck
Copy link
Member Author

Fixed in the develop branches of all affected repositories.
Automatic CI deploy:
https://readium.surge.sh
https://readium.firebaseapp.com

@danielweck danielweck pinned this issue Feb 9, 2022
@danielweck
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant