Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dc:source and dc:rights not in RWPM JSON Schema / JSON-LD context, not in EPUB parsing rules #26

Open
danielweck opened this issue Aug 12, 2020 · 0 comments

Comments

@danielweck
Copy link
Member

See: readium/webpub-manifest#66 (comment)

This code should be disabled (this will trigger the AdditionalJSON property and dc:source will be preserved "as is"):

// TODO: not in JSON Schema?? https://github.com/readium/webpub-manifest/issues/14
// tslint:disable-next-line:max-line-length
// https://github.com/readium/webpub-manifest/blob/0976680e25852b8a4c4802a052ba750ab3e89284/schema/metadata.schema.json
@JsonProperty("source")
public Source!: string;

// TODO: not in JSON Schema??
// tslint:disable-next-line:max-line-length
// https://github.com/readium/webpub-manifest/blob/0976680e25852b8a4c4802a052ba750ab3e89284/schema/metadata.schema.json
@JsonProperty("rights")
public Rights!: string;

if (opf.Metadata.Source && opf.Metadata.Source.length) {
publication.Metadata.Source = opf.Metadata.Source[0];
}

This code remains:

@XmlXPathSelector("dc:source/text()")
@XmlItemType(String)
public Source!: string[];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant