Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Bug report]: Layout shift occurring in the header section due to the initial position of the scrollbar on the page #1489

Closed
4 tasks done
fru2 opened this issue Apr 9, 2024 · 2 comments
Assignees
Labels
💻 aspect: code Concerns the software code in the repository bug Something isn't working 🛠 goal: fix Bug fix 🏁 status: ready for dev Ready for work

Comments

@fru2
Copy link

fru2 commented Apr 9, 2024

Descrcibe the bug?

When switching from the main homepage (https://reactplay.io/) to the plays page (https://reactplay.io/plays), a noticeable layout shift occurs in the header section due to different initial position of the scrollbar on the respective pages.

Steps to reproduce the bug?

  1. Go to the homepage (https://reactplay.io/)
  2. Click on the Browse button in the header section

Expected behavior

The size of the header section should remain consistent through all the pages.

Desktop (Please provide your system information)

OS: Windows
Browser: Chrome
Version: 123.0.6312.106

Mobile (Please provide your device information)

No response

Screenshot / Screenshare

reactplay

Relevant log output

No response

Record

Code of Conduct

  • I agree to follow this project's Code of Conduct
@fru2 fru2 added bug Something isn't working 💻 aspect: code Concerns the software code in the repository 🚦status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix labels Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

To reduce notifications, issues are locked. Your issue will be unlocked when we add the label 🏁 status: ready for dev.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2024
@reactplay reactplay unlocked this conversation Apr 10, 2024
@priyankarpal priyankarpal added 🏁 status: ready for dev Ready for work and removed 🚦status: awaiting triage Has not been triaged & therefore, not ready for work labels Apr 10, 2024
fru2 added a commit to fru2/react-play that referenced this issue Apr 16, 2024
Resolve layout shift in header section when switching between home and plays routes. Ensure consistent styling for main section across routes by adjusting overflow-x and min-height properties and wrapping the main tag (in Home Component) with "app-body" className.

Fix reactplay#1489
@fru2
Copy link
Author

fru2 commented Apr 16, 2024

I tried to fix the issue but it seems that the previous behavior is intentional because the landing page is not looking good with fixed header (just like other routes.)

@fru2 fru2 closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository bug Something isn't working 🛠 goal: fix Bug fix 🏁 status: ready for dev Ready for work
Projects
None yet
Development

No branches or pull requests

2 participants