Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [Bug report]: add border to the play card on the home page #1477

Closed
3 of 4 tasks
priyankarpal opened this issue Mar 2, 2024 · 4 comments · Fixed by #1478
Closed
3 of 4 tasks

🐛 [Bug report]: add border to the play card on the home page #1477

priyankarpal opened this issue Mar 2, 2024 · 4 comments · Fixed by #1478
Labels
💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software bug Something isn't working 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🏁 status: ready for dev Ready for work

Comments

@priyankarpal
Copy link
Member

Descrcibe the bug?

we need to add a border on the home page to identify the card. currently, it's difficult to identify the cards.

Steps to reproduce the bug?

.

Expected behavior

.

Desktop (Please provide your system information)

.

Mobile (Please provide your device information)

No response

Screenshot / Screenshare

Screenshot_2024-03-02_20-16-37

Relevant log output

No response

Record

Code of Conduct

  • I agree to follow this project's Code of Conduct
@priyankarpal priyankarpal added bug Something isn't working help wanted Open to participation from the community good first issue New-contributor friendly 🏁 status: ready for dev Ready for work 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software labels Mar 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2024

Hey! contributor, thank you for opening an Issue 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@priyankarpal
Copy link
Member Author

If you have any suggestions, please feel free to share them with us

@IdoBouskila
Copy link
Contributor

IdoBouskila commented Mar 4, 2024 •
edited
Loading

If you have any suggestions, please feel free to share them with us

What do you think about those? @priyankarpal

Option 1 Option 2
image image

@priyankarpal
Copy link
Member Author

Add an initial border for the cards. Also, use less hover effect

image

@Siddharth-Dagar-25 Siddharth-Dagar-25 mentioned this issue Mar 6, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software bug Something isn't working 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🏁 status: ready for dev Ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add border to the play card on the home page Siddharth-Dagar-25/react-play
2 participants
@priyankarpal @IdoBouskila