Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Bug report]: center banner texts #1449

Closed
3 of 4 tasks
priyankarpal opened this issue Feb 14, 2024 · 11 comments
Closed
3 of 4 tasks

🐛 [Bug report]: center banner texts #1449

priyankarpal opened this issue Feb 14, 2024 · 11 comments
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software bug Something isn't working 🛠 goal: fix Bug fix good first issue New-contributor friendly 🏁 status: ready for dev Ready for work

Comments

@priyankarpal
Copy link
Member

Descrcibe the bug?

visit https://reactplay.io/plays & see the banner text is in the wrong position. we need to fix the position left side & middle

Steps to reproduce the bug?

.

Expected behavior

.

Desktop (Please provide your system information)

kali linux
brave
latest

Mobile (Please provide your device information)

.

Screenshot / Screenshare

image

Relevant log output

No response

Record

Code of Conduct

  • I agree to follow this project's Code of Conduct
@priyankarpal priyankarpal added bug Something isn't working help wanted Open to participation from the community good first issue New-contributor friendly 🏁 status: ready for dev Ready for work 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software labels Feb 14, 2024
Copy link

Hey! contributor, thank you for opening an Issue 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@karthiknadar1204
Copy link

If this issue is up for grabs,I would like to work on it,marking my first pr to the repo

@priyankarpal priyankarpal removed the help wanted Open to participation from the community label Feb 14, 2024
@priyankarpal
Copy link
Member Author

If this issue is up for grabs,I would like to work on it,marking my first pr to the repo

assigned to you

@prasenarthi
Copy link

I would like to fix this bug

@priyankarpal
Copy link
Member Author

I would like to fix this bug

already assigned to someone you can check another issues

@Akshaygore1
Copy link
Contributor

a simple change is there for this

.dynamic-banner-container {
color: #fff;
justify-content: flex-start;
position: flex; // delete this
width: 100%;

 // add these 2
display: flex;
align-items: center;

}

@karthiknadar1204
Copy link

have started the work, had my exams going on so was a bit inactive

@priyankarpal
Copy link
Member Author

hello @karthiknadar1204 any updates?

@Akshaygore1
Copy link
Contributor

hello @karthiknadar1204 any updates?

should i do it can you assign to me @priyankarpal

@priyankarpal
Copy link
Member Author

hello @karthiknadar1204 any updates?

should i do it can you assign to me @priyankarpal

sure

@Akshaygore1
Copy link
Contributor

#1471

Fixed @priyankarpal

priyankarpal added a commit to Akshaygore1/react-play that referenced this issue Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software bug Something isn't working 🛠 goal: fix Bug fix good first issue New-contributor friendly 🏁 status: ready for dev Ready for work
Projects
None yet
Development

No branches or pull requests

4 participants