Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cra to vite create play service update #41

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ammaaraslam
Copy link
Member

Description

This PR is to update the current "create play service" to adhere to the recent migration of the ReactPlay platform from CRA to Vite. This includes changes only targeted towards the play template of js to use .jsx file extension for play templates.

Fixes #38

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the create play service according to the new platform requirement
1 participant