Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] React 17 #678

Closed
eps1lon opened this issue Oct 29, 2020 · 1 comment
Closed

[RFC] React 17 #678

eps1lon opened this issue Oct 29, 2020 · 1 comment

Comments

@eps1lon
Copy link
Collaborator

eps1lon commented Oct 29, 2020 •
edited
Loading

What would you like improved?

Support react 17.

  1. widen peer dependency range or change it to require 17
  2. test with 17

Since enzyme needs some time with React 17 (enzymejs/enzyme#2430) it might be worth investigating if @testing-library/react is sufficient for testing in this repository. I haven't looked closely since I wanted to get maintainer input before proposing such a big change to the repo internal.
@youchann youchann mentioned this issue Nov 20, 2020
Closed
@eps1lon
Copy link
Collaborator Author

eps1lon commented Dec 13, 2020

Just realized that >=16.6.0 is specified so 17.0 already matches. Still filed a PR that adds a testing setup for 16 and 17 so that we know we're safe.

@eps1lon eps1lon closed this as completed Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eps1lon