Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Example of Bug Due to Mutation in "Dangers of Mutability" #568

Open
rmorshea opened this issue Jan 5, 2022 · 6 comments · May be fixed by #1052
Open

Add Example of Bug Due to Mutation in "Dangers of Mutability" #568

rmorshea opened this issue Jan 5, 2022 · 6 comments · May be fixed by #1052
Labels
flag-good-first-issue A well defined and self-contained task. priority-3-low May be resolved one any timeline. type-docs About changes and updates to documentation

Comments

@rmorshea
Copy link
Collaborator

rmorshea commented Jan 5, 2022

Include something like this example in the "Dangers of Mutability" docs.
@rmorshea rmorshea added the type-docs About changes and updates to documentation label Jan 11, 2022
@rmorshea rmorshea modified the milestones: 2.0, 1.0 Jan 11, 2022
@rmorshea rmorshea added the priority-3-low May be resolved one any timeline. label Jan 13, 2022
@rmorshea rmorshea added the flag-good-first-issue A well defined and self-contained task. label Feb 9, 2022
@rmorshea rmorshea mentioned this issue Nov 30, 2022
Closed
@rmorshea rmorshea modified the milestones: 1.0, 2.0 Jan 12, 2023
@rmorshea
Copy link
Collaborator Author

Gonna push doc issues to later since we're thinking of revamping docs anyway.

@Archmonger
Copy link
Contributor

I'm planning on handling all existing docs issues in the revamp

@rmorshea
Copy link
Collaborator Author

Can you add "closes #XXX" for the issues you plan to address?

@Archmonger
Copy link
Contributor

Added to #863

@Archmonger
Copy link
Contributor

I also propose we do not assign docs changes to version milestones anymore.

I don't think it makes much sense since versions are source code specific.

Maybe a GitHub milestone for "Docs Changes" is needed? But that might be pointless, may as well just filter using the type: docs tag.

@rmorshea
Copy link
Collaborator Author

Sounds good to me.

@Archmonger Archmonger removed this from the Luxury Features milestone Jan 29, 2023
@Archmonger Archmonger linked a pull request Jun 14, 2023 that will close this issue
Draft
@Archmonger Archmonger mentioned this issue Feb 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flag-good-first-issue A well defined and self-contained task. priority-3-low May be resolved one any timeline. type-docs About changes and updates to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite the docs reactive-python/reactpy
2 participants
@rmorshea @Archmonger