-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rethink snake_case
to camelCase
prop conversion
#1160
Comments
my opinion is that, in general, magic changes like renaming things aren't preferable. There's a couple things to consider about this:
As far as implementing the updated behavior if you move forward with the reversion - one could use a new keyword argument that doesn't make the mutation, and the position argument could be deprecated. Once the old positional argument is removed, the keyword argument could become the new positional one at a later minor version. I suppose you could also introduce a class that inherits from TypedDict and do a type check on the first arg. I haven't used TypeDict much but it appears so that you'd need to silence custom keys so I'm not sure how I feel about that. Since they are usually a known set, maybe that's a good thing? |
Current Situation
The
snake_case
tocamelCase
prop conversion was created with the theory that it should be zero impact.Related PR:
However, we've received our first report of this behavior causing incompatibilities with third party libraries. In this case, it was related to the Google auth library.
Proposed Actions
Either revert this change, or make it togglable through configuration settings.
The text was updated successfully, but these errors were encountered: