Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

componentWillReceiveProps has been renamed, and is not recommended for use. #66

Open
Cogneter opened this issue Jun 10, 2022 · 1 comment

Comments

@Cogneter
Copy link

I'm getting the following Warning in my browser's console:

react-native-logs.fx.ts:22 Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://reactjs.org/link/unsafe-component-lifecycles for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://reactjs.org/link/derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 18.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: WebView

I've checked and react-native-web-webview does have the following code:

  componentWillReceiveProps(nextProps) {
    if (
      this.props.source.uri !== nextProps.source.uri ||
      this.props.source.method !== nextProps.source.method ||
      this.props.source.body !== nextProps.source.body
    ) {
      this.handleSource(nextProps.source, nextProps.newWindow);
    }
  }

So it needs to be replaced with getDerivedStateFromProps. Here's additional info: https://stackoverflow.com/questions/58924617/componentwillreceiveprops-has-been-renamed

@Cogneter
Copy link
Author

On a related note, is this repo still maintained? There's a bunch of open issues and pull requests, and the last commit was in August 2020.
@Minishlink @AuroreM @pleportz @VinceBT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant