-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native Crash with RN - SIGSEGV - 245459.0.0 #132
Comments
A few other crash logs from the other crash reporting tool. Not necessarily the same crash. Samsung SM-N960U
OnePlus GM1917
Google Pixel 3 XL
|
Any ideas? If I'm right about this being an issue due to the SDK version being set to 29 (instead of 28), this will be an issue for a lot of people very shortly since RN will be upgrading to SDK 29 as well in the next major version. Seems to be happening quite randomly, but it is definitely happening very often (with about ~800 devices). |
I'm getting the exact same crashes and stacktraces on an arm64 build on Samsung SM-T830 but with API 28. Have you found anything else about this?
|
I haven't, sadly. I keep seeing these crashes, but they seem to be very rare. Thought they were related to the SDK upgrade, but if you're seeing them as well now I don't know what's really going on. However, I definitely didn't see these crashes before with SDK 28. |
In our app, we've seen a SEGV at libjsc.so:1013576 from at least Dec 28th 2019. It's affecting 0.2% of a large number of sessions, making it our most common crash. That's an offset of 0xf7748 in hex. This is for org.webkit:android-jsc:r245459. According to nm, it's in: 00000000000f7738 t _ZNK3JSC10AccessCase20propagateTransitionsERNS_11SlotVisitorE ...which is "JSC::AccessCase::propagateTransitions(JSC::SlotVisitor&) const" which is in the backtrace you've got in the issue description. I.e. there's a good chance the libjsc.so:1013576 crash is the same as the one in the issue description (although it's not completely certain unless decode more of the backtrace). |
I found the symbol by converting the offset to hex and looking it up in:
|
Decoding some more of the backtrace: 1013576 JSC::AccessCase::propagateTransitions(JSC::SlotVisitor&) const ...it's still matching up with what's in this issue's description. |
I've seen |
This seems to propose a viable fix: https://bugs.webkit.org/show_bug.cgi?id=200983 This mentions the problem too: |
Do you know if there's any chance of react native accepting a new JavaScriptCore build? If so, would it be better to patch the existing WebKit version or move to a version that already has the fix. I see that most development work has moved to hermes, but we can't use that yet since crashes from its fetch() memory leak cause more (and more serious) crashes than this SEGV. |
@jgreen210 isn't it just a matter of upgrading the jsc-android package? React Native uses a version by default, but an updated one can always be installed with npm. We would need to get those updates into the official |
This unmerged Draft PR includes the relevant patch: #124 |
The fix is also in this fork of this repo: Kudo#1 Published here: https://github.com/Kudo/jsc-android-buildscripts/releases/tag/v250230.2.0 This explains why published from a fork: There was a follow up release fixing some other issue: https://www.npmjs.com/package/@kudo-ci/jsc-android/v/250230.2.1 You'll need a yarn/npm version that's new enough to support version aliases. |
Any updates on this? These errors seem to be happening more and more frequently. |
We're still testing https://github.com/Kudo/jsc-android-buildscripts/releases/tag/v250230.2.1 in our app. So far, we've had enough user sessions to show that it's better than 245459.0.0 [in terms of crash numbers], with no crashes attributable to libjsc. |
Any chance of uploading fixed binaries? If not, which available JSC version is safest and most reliable? It would seem latest is not greatest here... |
@jgreen210 @Kudo i've tested your code |
We've still seen no crashes that we've attributed to libjsc with this build. That's for a large number of sessions. |
As we are experiencing the same issue and this is the most common error we are getting in our app, I am going to post our info so far, hopefully, it'll help. RAW exception:
Additional info:
Brands (only above 1%)
Models (only above 1%)
|
Seeing this on SDK 28 too. |
To expand on that, here's how I installed @kudo-ci/jsc-android with yarn:
Confirmed by |
Hi guys, I'm seeing the same issues on our app. Any fixes? |
@neoassyrian I don't think this project is being actively maintained anymore. It looks like Hermes is getting all the attention now. |
That's too bad, some projects like https://github.com/realm/realm-js are still postponing their hermes migration so we will be stuck with JSC at least until the end of the year. |
Switching to Hermes fixed my crashes. |
Good day! I have the same crash on react-native: 0.63.2, jsc-android: ^245459.0.0:
Any ideas how to solve it? |
a new version of jsc is out v250230.2.1 thanks to @Kudo |
Bug
After upgrading some dependencies (and most importantly compile sdk from 28 to 29), I'm starting to get random SIGSEGV crashes from various android devices
The following is the stack trace of one of them:
Environment info
React native info output:
Using the following build.gradle:
Library version: RN 0.61.5 default ("jsc-android": "^245459.0.0")
Steps To Reproduce
Unknown. Regular use, not related to any specific use case.
The text was updated successfully, but these errors were encountered: