Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI fixes #31

Open
saphal1998 opened this issue Aug 19, 2020 · 2 comments · Fixed by #33
Open

CI fixes #31

saphal1998 opened this issue Aug 19, 2020 · 2 comments · Fixed by #33
Labels
help wanted Extra attention is needed priority-3

Comments

@saphal1998
Copy link
Collaborator

  • Fix node version in the CI build
@saphal1998
Copy link
Collaborator Author

saphal1998 commented Aug 19, 2020 •
edited
Loading

husky is a dev dependency, and we do not want to throw engine errors for dev dependencies but only for dependencies.

I wonder if there's a way to solve this.

Screenshot 2020-08-20 at 1 13 17 AM

@saphal1998 saphal1998 mentioned this issue Aug 19, 2020
Merged
@saphal1998 saphal1998 self-assigned this Aug 20, 2020
@saphal1998 saphal1998 reopened this Aug 20, 2020
@saphal1998
Copy link
Collaborator Author

There is a temporary workaround in place right now, which adds a --ignore-engines flag to the yarn install command. There is a need to fix this.

@saphal1998 saphal1998 added help wanted Extra attention is needed priority-3 labels Aug 20, 2020
@saphal1998 saphal1998 removed their assignment Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed priority-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore engines added to pass checks react-native-community/hermes-profile-transformer
1 participant
@saphal1998