Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the dependency on TextEncoder and TextDecoder #8

Open
acostalima opened this issue Jan 18, 2021 · 0 comments
Open

Get rid of the dependency on TextEncoder and TextDecoder #8

acostalima opened this issue Jan 18, 2021 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@acostalima
Copy link
Collaborator

acostalima commented Jan 18, 2021

It should be possible to rewrite the code to not rely on both TextEncoder and TextDecoder, just like GitHub as done:

By removing the dependency on both APIs, the app's bundle size can be further reduced. Considering that React Native's environment does not provide these APIs, there would be no need to polyfill them anymore. However, we should, by default, check whether TextEncoder and TextDecoder are available and only then fallback.

@acostalima acostalima added enhancement New feature or request help wanted Extra attention is needed labels Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant