-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Technical planning and discussion #4
Comments
/cc @autonome |
I think this plan sounds good. If your rewrite does not increase bundle size, we can even consider swapping out |
I'd be very interested in a stable fetch polyfill that handles streams. By the way, I'm currently considering using https://github.com/joltup/rn-fetch-blob#drop-in-fetch-replacement, I'll debrief you of how it works. |
@cpojer Could you please give me permissions to maintain the repo? Thanks! |
@tex0l Thanks! I wasn't aware |
Done! |
@cpojer I'm not being able to publish the package under react-native-community's organization. Can you give me such permission? |
Ping @cpojer. |
@alloy Can you help? 🙏 |
Paging @Titozzz re moving packages out of the RNC namespace. What's the goal wrt new packages, can they still publish under the org name or should they publish to their own namespace? |
Everyone is moving out of the RNC Scope so yeah it should be published under its own name |
@Titozzz got it, thanks! I assume |
Published as |
@acostalima Did you manage to the the time to fix the Android issue? As I understand it your solution does not work on android devices currently. Thank you for the hard work you put into making it. I feel like the React team should be supporting this. It is rather important and it seems like a lot of libraries have had to work around this often by having to drop to native code which is extremely painful because it means that rather than allowing users to use already published and maintained libraries they need to make special one off ones for React Native. Regardless of what is popular for features this seems like a rather important problem to the platform at a fundamental level. It should be worked on so we don't need to duplicate libraries that do a bit more than simple HTTP requests. |
@cpojer I'm reaching out to follow up on a previous discussion about coming up with a custom Fetch API implementation for React Native at https://github.com/react-native-community/fetch with support for streaming (facebook/react-native#27741). We, MOXY and Protocol Labs, are planning to start this effort shortly and we'd like to know your thoughts on the matter.
In short, what we currently have in mind is as follows:
ReadableStream
is available in RN's environment which can be polyfilled with web-streams-polyfill. IfReadableStream
is expected to only be used in the context of Fetch, we can probably bundle them together.Even if Facebook has no plans to add support for streaming to Fetch for the time being, app developers can easily swap out
whatwg-fetch
for@react-native-community/fetch
manually. Even better would be React Native to do this automatically via some sort of extension or plugin API.Are there any guidelines which React Native Community packages should conform to? e.g. linter and linting config, CI process config, etc.
CC @satazor @hugomrdias
The text was updated successfully, but these errors were encountered: