Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit button is missing #979

Open
bluebill1049 opened this issue Jun 21, 2023 · 3 comments
Open

Edit button is missing #979

bluebill1049 opened this issue Jun 21, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@bluebill1049
Copy link
Member

Looks like when we migrate those page, edit button is missing

image
@bluebill1049 bluebill1049 added the bug Something isn't working label Jun 21, 2023
@aranlucas
Copy link
Contributor

Coming from

documentation/src/components/logic/getEditLink.tsx

Line 22 in 30e71c2

} else if (pathname.includes("api")) {

should be matching url "docs" instead.

However, it might be better to leave it out until all the pages are migrated since there is no good way to determine the edit Link right now.

@bluebill1049
Copy link
Member Author

sounds good @aranlucas nice avatar. would you like to add yourself to the about us page?

@aranlucas
Copy link
Contributor

Maybe in the future when I get some more PR 🚀 and I can figure out a tag line haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aranlucas @bluebill1049