Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: columnResizable #1106

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

feat: columnResizable #1106

wants to merge 8 commits into from
+745 −110

Conversation

linxianxi
Copy link
Contributor

@linxianxi linxianxi commented Apr 8, 2024 •
edited by li-jia-nan
Loading

原先内部 onColumnResize 重命名为 onColumnWidthChange，进行区分

@vercel Vercel
Copy link

vercel bot commented Apr 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 5:33am

zombieJ
zombieJ reviewed Apr 9, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@linxianxi linxianxi requested a review from zombieJ April 12, 2024 05:44
zombieJ
zombieJ reviewed Apr 12, 2024
View reviewed changes
src/Table.tsx Outdated Show resolved Hide resolved
zombieJ
zombieJ reviewed Apr 12, 2024
View reviewed changes
src/Cell/index.tsx Outdated Show resolved Hide resolved
@zombieJ
Copy link
Member

zombieJ commented Apr 23, 2024

体验有点怪异，如果是超出 width 的时候缩小应该就是缩小，不应该把右边的撑开才对。

@zombieJ
Copy link
Member

zombieJ commented May 10, 2024

看起来好像没对齐

截屏2024-05-10 13 56 36

@linxianxi
Copy link
Contributor Author

看起来好像没对齐

截屏2024-05-10 13 56 36

故意放在最右侧左边的，没有放在最右侧中间。因为可能会因为 ellipsis 设置造成 超出部分不显示

@codecov Codecov
Copy link

codecov bot commented May 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (facc838) to head (875626c).
Report is 6 commits behind head on master.

❗ Current head 875626c differs from pull request most recent head 696ddd4

Please upload reports for the commit 696ddd4 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1106      +/-   ##
==========================================
+ Coverage   97.96%   98.06%   +0.09%     
==========================================
  Files          51       53       +2     
  Lines        4674     4913     +239     
  Branches      597      627      +30     
==========================================
+ Hits         4579     4818     +239     
  Misses         91       91              
  Partials        4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan
Copy link
Member

mark

@yoyo837
Copy link
Member

yoyo837 commented Sep 6, 2024

mark 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ Awaiting requested review from zombieJ

@crazyair crazyair Awaiting requested review from crazyair

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@linxianxi @zombieJ @li-jia-nan @yoyo837 @crazyair