Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

固定表头带children & [fixed:'right']的样式问题 #44974

Open
paradox010 opened this issue Sep 20, 2023 · 7 comments · May be fixed by react-component/table#1028
Open

固定表头带children & [fixed:'right']的样式问题 #44974

paradox010 opened this issue Sep 20, 2023 · 7 comments · May be fixed by react-component/table#1028
Labels
🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive

Comments

@paradox010
Copy link

Reproduction link

Edit on CodeSandbox

Steps to reproduce

const columns = [
{
    title: "Name",
    dataIndex: "name",
    key: "name",
    width: 100,
    fixed: "left",
},
...,
{
    title: "Gender",
    children: [
      {
        title: "vvv",
        dataIndex: "vvv",
        key: "vvvvv",
        width: 80,
        fixed: "right"
      }
    ]
  }
]

What is expected?

右侧Gender表头的className应当包括ant-table-cell-fix-right-first,即滚动时应当带有阴影和边框

What is actually happening?

样式缺失

Environment Info
antd 5.9.2
React 18.0.0
System macos
Browser chrome 116.0.5845.187

源码只对叶子节点添加了这个样式,按理来说相关叶子节点的父节点都应该添加该样式

@zombieJ zombieJ added 🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. and removed unconfirmed labels Sep 20, 2023
@github-actions
Copy link
Contributor

Hello @paradox010. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @paradox010,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

@ccj-007
Copy link

ccj-007 commented Sep 21, 2023

@zombieJ let me try

@liangkuku
Copy link

@zombieJ I would like to attempt to resolve this issue, but upstairs first.

@kampiu
Copy link
Contributor

kampiu commented Sep 22, 2023

I checked the components that need to be adjusted, and I traced that the problem that needs to be adjusted is in the rc-table package, roughly at

/src/Header/HeaderRow.tsx
/src/utils/fixUtil.ts

these files

@kampiu
Copy link
Contributor

kampiu commented Sep 22, 2023

image

There is a problem with the logic processing here. It should be correct when the child of the cell has only a single element and all its children are satisfied, right?

@liangkuku
Copy link

image There is a problem with the logic processing here. It should be correct when the child of the cell has only a single element and all its children are satisfied, right?

I checked the components that need to be adjusted, and I traced that the problem that needs to be adjusted is in the rc-table package, roughly at

/src/Header/HeaderRow.tsx
/src/utils/fixUtil.ts

these files

I see your pr it's wonderful.

@raintoway
Copy link

问题是中文的,你门评论是英文的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants