Revert "feat: improve a11y (#292)"

This reverts commit d3de52f.
react-component · Nov 20, 2024 · 481850f · 481850f
1 parent 9e147ab
commit 481850f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 13 deletions.
diff --git a/src/index.tsx b/src/index.tsx
@@ -38,12 +38,11 @@ export const Checkbox = forwardRef<CheckboxRef, CheckboxProps>((props, ref) => {
     type = 'checkbox',
     title,
     onChange,
-    children,
     ...inputProps
   } = props;
 
   const inputRef = useRef<HTMLInputElement>(null);
-  const holderRef = useRef<HTMLLabelElement>(null);
+  const holderRef = useRef<HTMLElement>(null);
 
   const [rawValue, setRawValue] = useMergedState(defaultChecked, {
     value: checked,
@@ -91,7 +90,7 @@ export const Checkbox = forwardRef<CheckboxRef, CheckboxProps>((props, ref) => {
   };
 
   return (
-    <label className={classString} title={title} style={style} ref={holderRef}>
+    <span className={classString} title={title} style={style} ref={holderRef}>
       <input
         {...inputProps}
         className={`${prefixCls}-input`}
@@ -102,8 +101,7 @@ export const Checkbox = forwardRef<CheckboxRef, CheckboxProps>((props, ref) => {
         type={type}
       />
       <span className={`${prefixCls}-inner`} />
-      {children !== undefined && <span>{children}</span>}
-    </label>
+    </span>
   );
 });
 

diff --git a/tests/__snapshots__/index.test.tsx.snap b/tests/__snapshots__/index.test.tsx.snap
@@ -1,7 +1,7 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`rc-checkbox click checkbox 1`] = `
-<label
+<span
   class="rc-checkbox"
 >
   <input
@@ -11,11 +11,11 @@ exports[`rc-checkbox click checkbox 1`] = `
   <span
     class="rc-checkbox-inner"
   />
-</label>
+</span>
 `;
 
 exports[`rc-checkbox click radio 1`] = `
-<label
+<span
   class="rc-checkbox rc-checkbox-checked"
 >
   <input
@@ -25,11 +25,11 @@ exports[`rc-checkbox click radio 1`] = `
   <span
     class="rc-checkbox-inner"
   />
-</label>
+</span>
 `;
 
 exports[`rc-checkbox control mode 1`] = `
-<label
+<span
   class="rc-checkbox rc-checkbox-checked"
 >
   <input
@@ -40,11 +40,11 @@ exports[`rc-checkbox control mode 1`] = `
   <span
     class="rc-checkbox-inner"
   />
-</label>
+</span>
 `;
 
 exports[`rc-checkbox works 1`] = `
-<label
+<span
   class="rc-checkbox"
 >
   <input
@@ -54,5 +54,5 @@ exports[`rc-checkbox works 1`] = `
   <span
     class="rc-checkbox-inner"
   />
-</label>
+</span>
 `;