From af1f2a8e4a067103e03f0edfd0330906518f0039 Mon Sep 17 00:00:00 2001 From: jbat Date: Wed, 1 May 2024 09:39:02 +1000 Subject: [PATCH] fix rest of typos --- lib/superset/dashboard/bulk_delete.rb | 2 +- lib/superset/dashboard/list.rb | 2 +- lib/superset/dataset/bulk_delete.rb | 2 +- lib/superset/tag/add_to_object.rb | 2 +- spec/superset/dashboard/bulk_delete_spec.rb | 2 +- spec/superset/dataset/bulk_delete_spec.rb | 2 +- spec/superset/tag/add_to_object_spec.rb | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/superset/dashboard/bulk_delete.rb b/lib/superset/dashboard/bulk_delete.rb index 2150fd9..9493be5 100644 --- a/lib/superset/dashboard/bulk_delete.rb +++ b/lib/superset/dashboard/bulk_delete.rb @@ -17,7 +17,7 @@ def initialize(dashboard_ids: []) def perform raise InvalidParameterError, "dashboard_ids array of integers expected" unless dashboard_ids.is_a?(Array) - raise InvalidParameterError, "dashboard_ids array must contin Integer only values" unless dashboard_ids.all? { |item| item.is_a?(Integer) } + raise InvalidParameterError, "dashboard_ids array must contain Integer only values" unless dashboard_ids.all? { |item| item.is_a?(Integer) } logger.info("Attempting to delete dashboards with id: #{dashboard_ids.join(', ')}") response diff --git a/lib/superset/dashboard/list.rb b/lib/superset/dashboard/list.rb index 7771238..1b54fc6 100644 --- a/lib/superset/dashboard/list.rb +++ b/lib/superset/dashboard/list.rb @@ -91,7 +91,7 @@ def list_attributes def validate_constructor_args raise InvalidParameterError, "title_contains must be a String type" unless title_contains.is_a?(String) raise InvalidParameterError, "tags_equal must be an Array type" unless tags_equal.is_a?(Array) - raise InvalidParameterError, "tags_equal array must contin string only values" unless tags_equal.all? { |item| item.is_a?(String) } + raise InvalidParameterError, "tags_equal array must contain string only values" unless tags_equal.all? { |item| item.is_a?(String) } raise InvalidParameterError, "ids_not_in must be an Array type" unless ids_not_in.is_a?(Array) end end diff --git a/lib/superset/dataset/bulk_delete.rb b/lib/superset/dataset/bulk_delete.rb index 434a62e..912285c 100644 --- a/lib/superset/dataset/bulk_delete.rb +++ b/lib/superset/dataset/bulk_delete.rb @@ -17,7 +17,7 @@ def initialize(dataset_ids: []) def perform raise InvalidParameterError, "dataset_ids array of integers expected" unless dataset_ids.is_a?(Array) - raise InvalidParameterError, "dataset_ids array must contin Integer only values" unless dataset_ids.all? { |item| item.is_a?(Integer) } + raise InvalidParameterError, "dataset_ids array must contain Integer only values" unless dataset_ids.all? { |item| item.is_a?(Integer) } logger.info("Attempting to delete datasets with id: #{dataset_ids.join(', ')}") response diff --git a/lib/superset/tag/add_to_object.rb b/lib/superset/tag/add_to_object.rb index 66a6c1e..1a0e5bb 100644 --- a/lib/superset/tag/add_to_object.rb +++ b/lib/superset/tag/add_to_object.rb @@ -33,7 +33,7 @@ def validate_constructor_args raise InvalidParameterError, "object_type_id is not a known value" unless ObjectType.list.include?(object_type_id) raise InvalidParameterError, "object_id integer is required" unless object_id.present? && object_id.is_a?(Integer) raise InvalidParameterError, "tags array is required" unless tags.present? && tags.is_a?(Array) - raise InvalidParameterError, "tags array must contin string only values" unless tags.all? { |item| item.is_a?(String) } + raise InvalidParameterError, "tags array must contain string only values" unless tags.all? { |item| item.is_a?(String) } end private diff --git a/spec/superset/dashboard/bulk_delete_spec.rb b/spec/superset/dashboard/bulk_delete_spec.rb index 2d64237..c51c51d 100644 --- a/spec/superset/dashboard/bulk_delete_spec.rb +++ b/spec/superset/dashboard/bulk_delete_spec.rb @@ -20,7 +20,7 @@ let(:dashboard_ids) { [1, 'string'] } it 'raises an error' do - expect { subject.perform }.to raise_error(Superset::Request::InvalidParameterError, "dashboard_ids array must contin Integer only values") + expect { subject.perform }.to raise_error(Superset::Request::InvalidParameterError, "dashboard_ids array must contain Integer only values") end end diff --git a/spec/superset/dataset/bulk_delete_spec.rb b/spec/superset/dataset/bulk_delete_spec.rb index b352ab4..c939eff 100644 --- a/spec/superset/dataset/bulk_delete_spec.rb +++ b/spec/superset/dataset/bulk_delete_spec.rb @@ -20,7 +20,7 @@ let(:dataset_ids) { [1, 'string'] } it 'raises an error' do - expect { subject.perform }.to raise_error(Superset::Request::InvalidParameterError, "dataset_ids array must contin Integer only values") + expect { subject.perform }.to raise_error(Superset::Request::InvalidParameterError, "dataset_ids array must contain Integer only values") end end diff --git a/spec/superset/tag/add_to_object_spec.rb b/spec/superset/tag/add_to_object_spec.rb index 615d21b..37f90c3 100644 --- a/spec/superset/tag/add_to_object_spec.rb +++ b/spec/superset/tag/add_to_object_spec.rb @@ -88,7 +88,7 @@ let(:tags) { [1, 2] } it 'raises an error' do - expect { subject.perform }.to raise_error(Superset::Request::InvalidParameterError, "tags array must contin string only values") + expect { subject.perform }.to raise_error(Superset::Request::InvalidParameterError, "tags array must contain string only values") end end end