Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IntersectionObserver'ed loader #3

Closed
rdmurphy opened this issue Jan 2, 2019 · 2 comments
Closed

IntersectionObserver'ed loader #3

rdmurphy opened this issue Jan 2, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@rdmurphy
Copy link
Owner

rdmurphy commented Jan 2, 2019

It may not make sense to be in this library itself — could see perhaps a @newswire/frames-loader? But it'd be nice to have an automatic, smart way to only load embeds when they are needed. I think it'd be too much to build this into the library as a default (would probably double the code base), but it could be an automatic thing in the same vein as the auto initializer.
@rdmurphy rdmurphy added the enhancement New feature or request label Jan 2, 2019
@rdmurphy
Copy link
Owner Author

rdmurphy commented Mar 9, 2021

Two(!) years out from this suggestion, now that native loading=lazy support is coming to iframes, it may be best to either 1) defer to this functionality or 2) provide an alternative bootstrapping method that observes existing iframes instead of creating them.

@rdmurphy
Copy link
Owner Author

rdmurphy commented Jan 4, 2022

The 2) option now exists in 1.0.0 — best to just let this be a user land activity, I think. Maybe could come back into play with #21? Or when/if #2 happens it's a part of that?

@rdmurphy rdmurphy closed this as completed Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rdmurphy