From a8d8a2b02d334ab32dc34468db65bfb42afa7a4f Mon Sep 17 00:00:00 2001 From: "Shah, Kevin" Date: Wed, 27 Sep 2023 10:57:05 -0400 Subject: [PATCH 1/2] fix: Updated Discovery.launch example with xrn:firebolt:application-type --- package-lock.json | 4 ++-- src/openrpc/discovery.json | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package-lock.json b/package-lock.json index 624619eec..314ef9a6c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -16855,7 +16855,7 @@ }, "src/sdks/core": { "name": "@firebolt-js/sdk", - "version": "0.17.1", + "version": "0.18.0-next.2", "license": "Apache-2.0", "devDependencies": { "jest": "^28.1.0", @@ -16865,7 +16865,7 @@ }, "src/sdks/manage": { "name": "@firebolt-js/manage-sdk", - "version": "0.17.1", + "version": "0.18.0-next.2", "license": "Apache-2.0", "devDependencies": { "jest": "^28.1.0", diff --git a/src/openrpc/discovery.json b/src/openrpc/discovery.json index 949ff09a5..68774ca61 100644 --- a/src/openrpc/discovery.json +++ b/src/openrpc/discovery.json @@ -971,7 +971,7 @@ ] } ], - "summary": "Launch or foreground the specified app, and optionally instructs it to navigate to the specified user action", + "summary": "Launch or foreground the specified app, and optionally instructs it to navigate to the specified user action. \n For the Primary Experience, the appId can any one of
urn:firebolt:apps:main
xrn:firebolt:application-type:main
or xrn:firebolt:application-type:settings", "params": [ { "name": "appId", @@ -1175,7 +1175,7 @@ "params": [ { "name": "appId", - "value": "urn:firebolt:apps:main" + "value": "xrn:firebolt:application-type:settings " }, { "name": "intent", @@ -1225,7 +1225,7 @@ "params": [ { "name": "appId", - "value": "urn:firebolt:apps:main" + "value": "xrn:firebolt:application-type:main " }, { "name": "intent", From 3210a9261da204daf51580dd19d15a5c6ba498bd Mon Sep 17 00:00:00 2001 From: "Shah, Kevin" Date: Thu, 28 Sep 2023 16:46:30 -0400 Subject: [PATCH 2/2] fix: addressed review comments --- src/openrpc/discovery.json | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/openrpc/discovery.json b/src/openrpc/discovery.json index 68774ca61..eb7530a35 100644 --- a/src/openrpc/discovery.json +++ b/src/openrpc/discovery.json @@ -444,7 +444,7 @@ "schema": { "$ref": "https://meta.comcast.com/firebolt/discovery#/definitions/PurchasedContentResult" }, - "summary": "The data for the purachasedContent" + "summary": "The data for the purchasedContent" } ], "result": { @@ -971,7 +971,7 @@ ] } ], - "summary": "Launch or foreground the specified app, and optionally instructs it to navigate to the specified user action. \n For the Primary Experience, the appId can any one of
urn:firebolt:apps:main
xrn:firebolt:application-type:main
or xrn:firebolt:application-type:settings", + "summary": "Launch or foreground the specified app, and optionally instructs it to navigate to the specified user action. \n For the Primary Experience, the appId can be any one of: \n\n - xrn:firebolt:application-type:main \n\n - xrn:firebolt:application-type:settings", "params": [ { "name": "appId", @@ -1079,7 +1079,7 @@ "params": [ { "name": "appId", - "value": "urn:firebolt:apps:main" + "value": "xrn:firebolt:application-type:main" }, { "name": "intent", @@ -1106,7 +1106,7 @@ "params": [ { "name": "appId", - "value": "urn:firebolt:apps:main" + "value": "xrn:firebolt:application-type:main" }, { "name": "intent", @@ -1131,7 +1131,7 @@ "params": [ { "name": "appId", - "value": "urn:firebolt:apps:main" + "value": "xrn:firebolt:application-type:main" }, { "name": "intent", @@ -1153,7 +1153,7 @@ "params": [ { "name": "appId", - "value": "urn:firebolt:apps:main" + "value": "xrn:firebolt:application-type:main" }, { "name": "intent", @@ -1200,7 +1200,7 @@ "params": [ { "name": "appId", - "value": "urn:firebolt:apps:main" + "value": "xrn:firebolt:application-type:main" }, { "name": "intent", @@ -1221,7 +1221,7 @@ } }, { - "name": "Launch the Aggregated Experience to the App Store details page for a specfic app with the ID 'foo'.", + "name": "Launch the Aggregated Experience to the App Store details page for a specific app with the ID 'foo'.", "params": [ { "name": "appId", @@ -1302,7 +1302,7 @@ ] } ], - "summary": "Inform the platform that your user is signed in, for increased visiblity in search & discovery. Sign-in state is used separately from what content can be access through entitlements and availabilities. Sign-in state may be used when deciding whether to choose this app to handle a user intent. For instance, if the user tries to launch something generic like playing music from an artist, only a signed-in app will be chosen. If the user wants to tune to a channel, only a signed-in app will be chosen to handle that intent. While signIn can optionally include entitlements as those typically change at signIn time, it is recommended to make a separate call to Discovery.contentAccess for entitlements. signIn is not only for when a user explicitly enters login credentials. If an app does not require any credentials from the user to consume content, such as in a free app, then the app should call signIn immediately on launch.", + "summary": "Inform the platform that your user is signed in, for increased visibility in search & discovery. Sign-in state is used separately from what content can be access through entitlements and availabilities. Sign-in state may be used when deciding whether to choose this app to handle a user intent. For instance, if the user tries to launch something generic like playing music from an artist, only a signed-in app will be chosen. If the user wants to tune to a channel, only a signed-in app will be chosen to handle that intent. While signIn can optionally include entitlements as those typically change at signIn time, it is recommended to make a separate call to Discovery.contentAccess for entitlements. signIn is not only for when a user explicitly enters login credentials. If an app does not require any credentials from the user to consume content, such as in a free app, then the app should call signIn immediately on launch.", "params": [ { "name": "entitlements",