From 8741ea47739dd5e0de772528f838329ef3a914e5 Mon Sep 17 00:00:00 2001 From: parag-pv Date: Thu, 3 Oct 2024 14:22:50 -0400 Subject: [PATCH] Comment changes --- .../core/src/cpp/sdk/cpptest/unit/accessibilityTest.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/sdks/core/src/cpp/sdk/cpptest/unit/accessibilityTest.cpp b/src/sdks/core/src/cpp/sdk/cpptest/unit/accessibilityTest.cpp index 276ec4281..09a6efc58 100644 --- a/src/sdks/core/src/cpp/sdk/cpptest/unit/accessibilityTest.cpp +++ b/src/sdks/core/src/cpp/sdk/cpptest/unit/accessibilityTest.cpp @@ -238,10 +238,8 @@ TEST_F(AccessibilityTest, subscribeOnClosedCaptionsSettingsChanged) Firebolt::IFireboltAccessor::Instance().AccessibilityInterface().subscribe(closedCaptionsChange, &error); std::cout << " error: " << static_cast(error) << std::endl; EXPECT_EQ(error, Firebolt::Error::None); - /* We could optionally return a response inside WaitForEventResponse using JSON engine's mockResponse - pointing to #/x-schemas/Types/ListenResponse dereferenced to "{listening:true}". - Since there is no return value for event subscription, error would be the only validation for now. - This is until event response is returned by changing closedCaptions settings. + /* Since there is no return value for event subscription, error would be the only validation for now. + Returning a mock event response from open rpc and validating it against expected values from open rpc might not be of value. This comment is applicable to all event unit tests. */ }