From 30eaac3e0f6f67b32e8b082c5301357c30771dbb Mon Sep 17 00:00:00 2001
From: Joe Martin <jwmartin83@gmail.com>
Date: Tue, 13 Aug 2024 12:18:38 -0400
Subject: [PATCH] fix: Update specs for resolutions

---
 .../specifications/media/media-capabilities.md  | 17 ++++++++++-------
 src/openrpc/display.json                        |  2 +-
 src/schemas/media.json                          |  5 ++++-
 3 files changed, 15 insertions(+), 9 deletions(-)

diff --git a/requirements/specifications/media/media-capabilities.md b/requirements/specifications/media/media-capabilities.md
index 87925165b..a235fed72 100644
--- a/requirements/specifications/media/media-capabilities.md
+++ b/requirements/specifications/media/media-capabilities.md
@@ -146,13 +146,15 @@ The Firebolt `Types` module must have a `Dimensions` object of the following sch
 
 The Firebolt `Media` module **MUST** have a `ResolutionName` enumeration:
 
-| Class     | Applicable Resolutions |
-| --------- | ---------------------- |
-| `sd`      | `576p` and lower       |
-| `hd`      | `720p`                 |
-| `fhd`     | `1080p`                |
-| `uhd`     | `2160` and higher      |
-| `unknown` | unknown or no display  |
+| Class     | Applicable Vertical Resolutions  |
+| --------- | -------------------------------- |
+| `sd`      | `576`                            |
+| `hd`      | `720`                            |
+| `fhd`     | `1080`                           |
+| `4k-uhd`  | `2160`                           |
+| `8k-uhd`  | `4320`                           |
+| `other`   | other or non-standard resolution |
+| `unknown` | unknown resolution / no display  |
 
 ### 3.4. Video Modes
 
@@ -181,6 +183,7 @@ The Firebolt `Media` module **MUST** have a `VideoMode` enumeration:
 - `2160p60`
 - `4320p50`
 - `4320p60`
+- `other`
 - `unknown`
 
 Any methods relating to the video mode (such as a device's video output mode) **MUST** return `Media.VideoMode` values.
diff --git a/src/openrpc/display.json b/src/openrpc/display.json
index e11532318..42b5d4b9d 100644
--- a/src/openrpc/display.json
+++ b/src/openrpc/display.json
@@ -234,7 +234,7 @@
                     "params": [],
                     "result": {
                         "name": "Default Result",
-                        "value": "uhd"
+                        "value": "4k-uhd"
                     }
                 }
             ]
diff --git a/src/schemas/media.json b/src/schemas/media.json
index 4127cf573..325826664 100644
--- a/src/schemas/media.json
+++ b/src/schemas/media.json
@@ -92,7 +92,9 @@
                 "sd",
                 "hd",
                 "fhd",
-                "uhd",
+                "4k-uhd",
+                "8k-uhd",
+                "other",
                 "unknown"
             ]
         },
@@ -135,6 +137,7 @@
                 "2160p60",
                 "4320p50",
                 "4320p60",
+                "other",
                 "unknown"
             ]
         }