From de35cb8073438f945bb4b7a8e8f420b8d6ba2358 Mon Sep 17 00:00:00 2001 From: Jeremy LaCivita Date: Tue, 12 Sep 2023 16:17:25 -0400 Subject: [PATCH 1/2] fix: Add enumerated values for fontFamily/fontEdge (#181) * fix: Add enumerated values for fontFamily/fontEdge * fix: Fixing example to match new enums --- src/openrpc/accessibility.json | 4 +-- src/openrpc/closed_captions.json | 4 +-- src/schemas/accessibility.json | 25 ++++++++++++++++--- .../manage/test/suite/closedCaptions.test.ts | 2 +- 4 files changed, 27 insertions(+), 8 deletions(-) diff --git a/src/openrpc/accessibility.json b/src/openrpc/accessibility.json index 7da0644c0..c010a6146 100644 --- a/src/openrpc/accessibility.json +++ b/src/openrpc/accessibility.json @@ -39,7 +39,7 @@ "value": { "enabled": true, "styles": { - "fontFamily": "Monospace sans-serif", + "fontFamily": "monospaced_sanserif", "fontSize": 1, "fontColor": "#ffffff", "fontEdge": "none", @@ -92,7 +92,7 @@ "value": { "enabled": true, "styles": { - "fontFamily": "Monospace sans-serif", + "fontFamily": "monospaced_sanserif", "fontSize": 1, "fontColor": "#ffffff", "fontEdge": "none", diff --git a/src/openrpc/closed_captions.json b/src/openrpc/closed_captions.json index da9fc1ad0..90fd21e90 100644 --- a/src/openrpc/closed_captions.json +++ b/src/openrpc/closed_captions.json @@ -73,7 +73,7 @@ "params": [], "result": { "name": "family", - "value": "monospace" + "value": "monospaced_sanserif" } }, { @@ -225,7 +225,7 @@ "params": [], "result": { "name": "edge", - "value": "solid" + "value": "uniform" } }, { diff --git a/src/schemas/accessibility.json b/src/schemas/accessibility.json index da1a8df38..ce6ad419a 100644 --- a/src/schemas/accessibility.json +++ b/src/schemas/accessibility.json @@ -11,14 +11,33 @@ ], "definitions": { "FontFamily": { - "type": ["string", "null"] + "type": ["string", "null"], + "enum": [ + "monospaced_serif", + "proportional_serif", + "monospaced_sanserif", + "proportional_sanserif", + "smallcaps", + "cursive", + "casual", + null + ] }, "FontSize": { "type": ["number", "null"], "minimum": 0 }, "FontEdge": { - "type": ["string", "null"] + "type": ["string", "null"], + "enum": [ + "none", + "raised", + "depressed", + "uniform", + "drop_shadow_left", + "drop_shadow_right", + null + ] }, "Color": { "type": ["string", "null"] @@ -103,7 +122,7 @@ { "enabled": true, "styles": { - "fontFamily": "Monospace sans-serif", + "fontFamily": "monospaced_serif", "fontSize": 1, "fontColor": "#ffffff", "fontEdge": "none", diff --git a/src/sdks/manage/test/suite/closedCaptions.test.ts b/src/sdks/manage/test/suite/closedCaptions.test.ts index 8d48bcf6d..90c15417f 100644 --- a/src/sdks/manage/test/suite/closedCaptions.test.ts +++ b/src/sdks/manage/test/suite/closedCaptions.test.ts @@ -27,7 +27,7 @@ test("ClosedCaptions.enabled()", () => { test("ClosedCaptions.fontFamily()", () => { return ClosedCaptions.fontFamily().then((res: string) => { - expect(res).toEqual("monospace"); + expect(res).toEqual("monospaced_sanserif"); }); }); From 27536e8e93451d6a401b2153c187681f6db7f963 Mon Sep 17 00:00:00 2001 From: semantic-release-bot Date: Tue, 12 Sep 2023 20:18:55 +0000 Subject: [PATCH 2/2] chore(release): 0.17.1-next.4 [skip ci] ## [0.17.1-next.4](https://github.com/rdkcentral/firebolt-apis/compare/v0.17.1-next.3...v0.17.1-next.4) (2023-09-12) ### Bug Fixes * Add enumerated values for fontFamily/fontEdge ([#181](https://github.com/rdkcentral/firebolt-apis/issues/181)) ([de35cb8](https://github.com/rdkcentral/firebolt-apis/commit/de35cb8073438f945bb4b7a8e8f420b8d6ba2358)) --- CHANGELOG.md | 7 +++++++ package-lock.json | 4 ++-- package.json | 2 +- src/sdks/core/package.json | 2 +- src/sdks/manage/package.json | 2 +- 5 files changed, 12 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ed39a7486..0246eb81f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,10 @@ +## [0.17.1-next.4](https://github.com/rdkcentral/firebolt-apis/compare/v0.17.1-next.3...v0.17.1-next.4) (2023-09-12) + + +### Bug Fixes + +* Add enumerated values for fontFamily/fontEdge ([#181](https://github.com/rdkcentral/firebolt-apis/issues/181)) ([de35cb8](https://github.com/rdkcentral/firebolt-apis/commit/de35cb8073438f945bb4b7a8e8f420b8d6ba2358)) + ## [0.17.1-next.3](https://github.com/rdkcentral/firebolt-apis/compare/v0.17.1-next.2...v0.17.1-next.3) (2023-09-12) diff --git a/package-lock.json b/package-lock.json index 7f3e8b835..a7056dc61 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@firebolt-js/sdks", - "version": "0.17.1-next.3", + "version": "0.17.1-next.4", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@firebolt-js/sdks", - "version": "0.17.1-next.3", + "version": "0.17.1-next.4", "license": "Apache-2.0", "workspaces": [ "src/sdks/core", diff --git a/package.json b/package.json index 99a17c311..7ceb84867 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@firebolt-js/sdks", - "version": "0.17.1-next.3", + "version": "0.17.1-next.4", "description": "The Firebolt JS SDK", "type": "module", "bin": { diff --git a/src/sdks/core/package.json b/src/sdks/core/package.json index 4e3188917..069f6f581 100644 --- a/src/sdks/core/package.json +++ b/src/sdks/core/package.json @@ -1,6 +1,6 @@ { "name": "@firebolt-js/sdk", - "version": "0.17.1-next.3", + "version": "0.17.1-next.4", "description": "The Firebolt JS SDK", "main": "./dist/lib/firebolt.mjs", "types": "./dist/lib/firebolt.d.ts", diff --git a/src/sdks/manage/package.json b/src/sdks/manage/package.json index 5db98663a..5c24b4803 100644 --- a/src/sdks/manage/package.json +++ b/src/sdks/manage/package.json @@ -1,6 +1,6 @@ { "name": "@firebolt-js/manage-sdk", - "version": "0.17.1-next.3", + "version": "0.17.1-next.4", "description": "The Firebolt Manage JS SDK", "main": "./dist/lib/firebolt-manage.mjs", "types": "./dist/lib/firebolt-manage.d.ts",