Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R4.3] [UI] [Interfaces] Compositor resolutions do not match other Thunder packages #93

Open
laurence-ejraee opened this issue Aug 8, 2023 · 0 comments

Comments

@laurence-ejraee
Copy link

laurence-ejraee commented Aug 8, 2023

I have encountered a bug where changing the Compositor plugin resolution using the web UI would not work for e.g. changing to resolution "720p50Hz".

I found the reason for this is the compositor resolution strings listed in the dropdown menu in the web UI still use the "Hz" suffix. However, the compositor resolutions (specifically the enum to string conversion) defined in Thunder Interfaces (Definitions.cpp) had the "Hz" suffix removed in rdkcentral/ThunderInterfaces@9d15587

To fix this bug, I removed the "Hz" prefix from Compositor resolutions in ThunderUI sources: dist/bundle.js and src/js/plugins/compositor.js.

@laurence-ejraee laurence-ejraee changed the title R4.3 Compositor resolutions do not match other Thunder packages [R4.3] Compositor resolutions do not match other Thunder packages Aug 8, 2023
@laurence-ejraee laurence-ejraee changed the title [R4.3] Compositor resolutions do not match other Thunder packages [R4.3] [UI] [Interfaces] Compositor resolutions do not match other Thunder packages Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant