We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To have capability to update a Thunder properties with any falsy https://developer.mozilla.org/en-US/docs/Glossary/Falsy values, the current makeBody functionality needs to be improved.
falsy
https://github.com/rdkcentral/ThunderJS/blob/master/tests/thunderJS.calls.spec.js
test('thunderJS - calls - argument based - empty string as an argument', assert => { resetStubsAndSpies() let thunderJS = ThunderJS(options) thunderJS.call('WebKitBrowser', 'userscripts', '') assert.ok( makeBodySpy.returned( sinon.match({ jsonrpc: '2.0', id: 1, method: 'WebKitBrowser.1.userscripts', params: '', }) ), 'Should make a jsonrpc body and method WebKitBrowser.1.userscripts and params' ) assert.end() })
The text was updated successfully, but these errors were encountered:
Apply fix regarding falsy params support - should relate to rdkcentra…
d0d8f04
…l/issues/36
@dzubitskyi I have a branch on my fork that attempts to address this issue - https://github.com/nunofaria/ThunderJS/tree/36-falsy-param-support - feel free to comment on the fix attempt, thanks
Sorry, something went wrong.
No branches or pull requests
To have capability to update a Thunder properties with any
falsy
https://developer.mozilla.org/en-US/docs/Glossary/Falsy values, the current makeBody functionality needs to be improved.Expected test suite
https://github.com/rdkcentral/ThunderJS/blob/master/tests/thunderJS.calls.spec.js
The text was updated successfully, but these errors were encountered: