From 0cf2d7f8636008f6abced7bd41c634eb2f9aa811 Mon Sep 17 00:00:00 2001 From: Mateusz Daniluk <121170681+VeithMetro@users.noreply.github.com> Date: Tue, 3 Oct 2023 12:27:18 +0200 Subject: [PATCH 1/5] Testing set -e to make actions fail on first error --- .github/workflows/Build ThunderClientLibraries on Windows.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/Build ThunderClientLibraries on Windows.yml b/.github/workflows/Build ThunderClientLibraries on Windows.yml index ea3c90ef..3f5ce8d3 100644 --- a/.github/workflows/Build ThunderClientLibraries on Windows.yml +++ b/.github/workflows/Build ThunderClientLibraries on Windows.yml @@ -2,7 +2,7 @@ name: Build ThunderClientLibraries on Windows on: push: - branches: ["master"] + branches: ["development/actions-windows"] # CHANGE BACK TO MASTER pull_request: branches: ["master"] workflow_call: @@ -116,6 +116,7 @@ jobs: - name: Build ThunderClientLibraries shell: cmd run: | + set -e cd ThunderOnWindows "%devEnv%" /Build "${{matrix.type}}|x${{matrix.version}}" /Project "%cryptography%" "%solution%" "%devEnv%" /Build "${{matrix.type}}|x${{matrix.version}}" /Project "%deviceinfo%" "%solution%" From 080cb9180b2b6a1b5139c46aae34bbe4a244eb83 Mon Sep 17 00:00:00 2001 From: Mateusz Daniluk <121170681+VeithMetro@users.noreply.github.com> Date: Tue, 3 Oct 2023 12:51:47 +0200 Subject: [PATCH 2/5] Trying $ErrorActionPreference = "Stop" --- .github/workflows/Build ThunderClientLibraries on Windows.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/Build ThunderClientLibraries on Windows.yml b/.github/workflows/Build ThunderClientLibraries on Windows.yml index 3f5ce8d3..18ae83c0 100644 --- a/.github/workflows/Build ThunderClientLibraries on Windows.yml +++ b/.github/workflows/Build ThunderClientLibraries on Windows.yml @@ -116,7 +116,7 @@ jobs: - name: Build ThunderClientLibraries shell: cmd run: | - set -e + $ErrorActionPreference = "Stop" cd ThunderOnWindows "%devEnv%" /Build "${{matrix.type}}|x${{matrix.version}}" /Project "%cryptography%" "%solution%" "%devEnv%" /Build "${{matrix.type}}|x${{matrix.version}}" /Project "%deviceinfo%" "%solution%" From 040466361dad0dfe3268f1881b6a3ccd85b539fa Mon Sep 17 00:00:00 2001 From: Mateusz Daniluk <121170681+VeithMetro@users.noreply.github.com> Date: Tue, 3 Oct 2023 15:17:37 +0200 Subject: [PATCH 3/5] Trying a new way of catching one fail --- .../Build ThunderClientLibraries on Windows.yml | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/.github/workflows/Build ThunderClientLibraries on Windows.yml b/.github/workflows/Build ThunderClientLibraries on Windows.yml index 18ae83c0..d3c3e27c 100644 --- a/.github/workflows/Build ThunderClientLibraries on Windows.yml +++ b/.github/workflows/Build ThunderClientLibraries on Windows.yml @@ -115,15 +115,14 @@ jobs: - name: Build ThunderClientLibraries shell: cmd - run: | - $ErrorActionPreference = "Stop" + run: > cd ThunderOnWindows - "%devEnv%" /Build "${{matrix.type}}|x${{matrix.version}}" /Project "%cryptography%" "%solution%" - "%devEnv%" /Build "${{matrix.type}}|x${{matrix.version}}" /Project "%deviceinfo%" "%solution%" - "%devEnv%" /Build "${{matrix.type}}|x${{matrix.version}}" /Project "%displayinfo%" "%solution%" - "%devEnv%" /Build "${{matrix.type}}|x${{matrix.version}}" /Project "%ocdm%" "%solution%" - "%devEnv%" /Build "${{matrix.type}}|x${{matrix.version}}" /Project "%securityagent%" "%solution%" - "%devEnv%" /Build "${{matrix.type}}|x${{matrix.version}}" /Project "%virtualinput%" "%solution%" + && "%devEnv%" /Build "${{matrix.type}}|x${{matrix.version}}" /Project "%cryptography%" "%solution%" + && "%devEnv%" /Build "${{matrix.type}}|x${{matrix.version}}" /Project "%deviceinfo%" "%solution%" + && "%devEnv%" /Build "${{matrix.type}}|x${{matrix.version}}" /Project "%displayinfo%" "%solution%" + && "%devEnv%" /Build "${{matrix.type}}|x${{matrix.version}}" /Project "%ocdm%" "%solution%" + && "%devEnv%" /Build "${{matrix.type}}|x${{matrix.version}}" /Project "%securityagent%" "%solution%" + && "%devEnv%" /Build "${{matrix.type}}|x${{matrix.version}}" /Project "%virtualinput%" "%solution%" - name: Tar files run: tar -czvf ${{matrix.type}}${{matrix.version}}.tar.gz artifacts From 44e9e9404cab0bfa3f4a59b820438662f5bb6bba Mon Sep 17 00:00:00 2001 From: Mateusz Daniluk <121170681+VeithMetro@users.noreply.github.com> Date: Mon, 9 Oct 2023 15:21:06 +0200 Subject: [PATCH 4/5] Prepare to pull request and merge --- .github/workflows/Build ThunderClientLibraries on Windows.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/Build ThunderClientLibraries on Windows.yml b/.github/workflows/Build ThunderClientLibraries on Windows.yml index d3c3e27c..c82ff7a3 100644 --- a/.github/workflows/Build ThunderClientLibraries on Windows.yml +++ b/.github/workflows/Build ThunderClientLibraries on Windows.yml @@ -2,7 +2,7 @@ name: Build ThunderClientLibraries on Windows on: push: - branches: ["development/actions-windows"] # CHANGE BACK TO MASTER + branches: ["master"] pull_request: branches: ["master"] workflow_call: From 4a8434c8ceac350c643d6bce26d632036de1d084 Mon Sep 17 00:00:00 2001 From: VeithMetro Date: Tue, 10 Oct 2023 10:11:27 +0200 Subject: [PATCH 5/5] Fixing a linking problem by adding an include of cryptography header file --- Source/cryptography/Cryptography.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/Source/cryptography/Cryptography.cpp b/Source/cryptography/Cryptography.cpp index cdf25f3a..474066f2 100644 --- a/Source/cryptography/Cryptography.cpp +++ b/Source/cryptography/Cryptography.cpp @@ -18,6 +18,7 @@ */ #include "Module.h" +#include "cryptography.h" #include