Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete regression fix on ziggo platforms #475

Closed
Sv-Th opened this issue Apr 19, 2023 · 2 comments
Closed

Incomplete regression fix on ziggo platforms #475

Sv-Th opened this issue Apr 19, 2023 · 2 comments

Comments

@Sv-Th
Copy link

Sv-Th commented Apr 19, 2023

Regarding following pull: #364

A new generation of hardware was released with the following user agent:
Mozilla/5.0 (Linux armv7l) AppleWebKit/602.1.28+ (KHTML, like Gecko) Version/9.1 Safari/601.5.17 HZN/4.46 (MN=2008C-STB-PROD;PC=EOS2STB;FV=EOS2008C-mon-web-00.05-157-ap-AL-20230209074548-na002;)

This causes the earlier mentioned regression fix to not function for users with new generation of boxes.
This reintroduces the blocky/missing text issue of #363

The fix could be as simple as adding || navigator.userAgent.indexOf('EOS2STB') !== -1 to the isZiggo utils check. However, something to keep in mind is that if or when a new generation is introduced, the issue could resurface.

@wouterlucas
Copy link
Contributor

I think its better if we take the whole User Agent detection thing out and make this a switchable setting people can configure. That way it's not bound to project specific devices and it's a generic setting people can turn on. Making it future proof for next iterations of the Ziggo HW.

@Sv-Th
Copy link
Author

Sv-Th commented Apr 20, 2023

Apparently this generic setting has already been added (#363 (comment)). A similar issue has been created in the past as well.

My mistake. I will be closing the issue and pull request in this case.

@Sv-Th Sv-Th closed this as completed Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants