Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning inspector retains previous text texture attributes when we've set the text to '' #373

Open
newmanja opened this issue Mar 9, 2022 · 1 comment
Labels

Comments

@newmanja
Copy link

newmanja commented Mar 9, 2022

Tracked by https://www.stb.bskyb.com/jira/browse/NGAPPS-9179 on our side.

Use lightning inspector to look at an element from a Lightning app with text 'foo' in it, and see attribute texture-text='foo'. In your Lightning app change the text to '' (empty string). In inspector... it still says texture-text='foo'.

I think the underlying issue stems from the fact that changing text from 'foo' to 'bar' means attaching a new texture, and that propagates through to the inspector nicely. Changing text to '' means removing the old texture but not attaching a new one; the inspector doesn't notice.

We have a kinda-workaround, relying on the fact that the w, h drop to 0px when there's no text, but this doesn't work if an explicit width or height has been set in the app (if the width and height are not derived from the text texture dimensions).

We're using Lightning core 2.6.0.

@g-zachar g-zachar added the bug label Mar 13, 2022
@chiefcll
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants