Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix is hard-coded in form. #25

Closed
satary opened this issue Apr 2, 2023 · 2 comments
Closed

Prefix is hard-coded in form. #25

satary opened this issue Apr 2, 2023 · 2 comments

Comments

@satary
Copy link

satary commented Apr 2, 2023

jupyterhub-announcement/templates/index.html

Line 17 in 5b9488a

<form action="/services/announcement/update" method="post" class="col-md-offset-3 col-md-6">

Request in a form always lead to '/services/announcement/update' ignoring c.AnnouncementService.service_prefix.
In some deployments, the hub is not running in the root.
@satary satary changed the title index template prefix is hard-coded in form. Prefix is hard-coded in form. Apr 2, 2023
@rcthomas
Copy link
Owner

@satary thanks for noticing this, do you happen to have a branch that fixes this you want to craft into a PR?

@rcthomas rcthomas mentioned this issue Jun 5, 2024
Merged
@rcthomas
Copy link
Owner

rcthomas commented Jun 5, 2024

Fixed in #29, released in 0.9.2

@rcthomas rcthomas closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rcthomas @satary