Skip to content
This repository has been archived by the owner on Jun 17, 2020. It is now read-only.

Integrate labels into rewards.rchain.coop #673

Closed
2 tasks done
ghost opened this issue May 8, 2018 · 24 comments
Closed
2 tasks done

Integrate labels into rewards.rchain.coop #673

ghost opened this issue May 8, 2018 · 24 comments
Assignees
Labels
Development splitting into core-dev, developer-education, ...? (guides: @dckc, ...) zz-Operations NEEDS SPONSOR guides: @TrenchFloat, @jimscarver @Tonyprisca13

Comments

@ghost
Copy link

ghost commented May 8, 2018

opened on behalf of @dckc

Benefit to RChain Coop and Community

Guides could easily review budgets on their issues.

Proposed Budget

$300 based on an estimate of 2 story points ($125 ea per #273) plus some training time.

Measure of Completion

  • rewards.rchain.coop sync integrates labels
  • guides are trained to use them

Legal

Task Submitter shall not submit Tasks that will involve RHOC being transacted in any manner that (i) jeopardizes RHOC’s status as a software access token or other relevant and applicable description of the RHOC as an “asset”—not a security— or (2) violates, in any manner, applicable U.S. Securities laws.

@ghost ghost added the zz-Operations NEEDS SPONSOR guides: @TrenchFloat, @jimscarver @Tonyprisca13 label May 8, 2018
@ghost ghost assigned dckc May 8, 2018
@dckc dckc added the Development splitting into core-dev, developer-education, ...? (guides: @dckc, ...) label May 8, 2018
@jimscarver
Copy link
Contributor

jimscarver commented May 8, 2018

Aadi and I started making this table for review of labeled issues https://rhobot.glitch.me/
As is the table can be copy pasted into a google sheet for cooperation amoung the reviewers of the label.
Here is the query I use

query:  {
  repository(owner: "rchain", name: "bounties") {
    issues(first: 100, labels: ["Governance"], states: [OPEN], orderBy: {field: UPDATED_AT, direction: DESC}) {
      nodes {
        number
        title
        author {login}
        updatedAt
        labels(first: 10) {
          nodes {
            name
          }
        }
      }
    }
  }
}

@jimscarver
Copy link
Contributor

@dckc We can extend https://rhobot.glitch.me/ to provide information from the mysql bounty database given credentials. Links into the bounty system for voting might also be good. Do you think this is a worthwhile activity or are there other plans?

@dckc
Copy link
Contributor

dckc commented May 14, 2018

It's probably worthwhile, especially if it happens before I find time for my idea: I intend to enhance the issue download stuff in rewards.rchain.coop to grab labels.

No credentials are needed to access any of the data in rewards.rchain.coop; it's all public. I think you can GET any data you like in CSV format... maybe JSON or XML too.

@lapin7
Copy link
Contributor

lapin7 commented May 15, 2018

Yeah, that's very powerful. Is all data from August 2017 onwards in the App?

@jimscarver
Copy link
Contributor

jimscarver commented May 15, 2018

@dckc We will want to access the bounty data real time but can use a snapshot for development.
Can you suggest how we might make a link to vote on an issue?
We plan to try setting up a graphql interface to mysql so that very little programming will be required to use it and so that it might be reconfigured to run on rchain easily.

@dckc
Copy link
Contributor

dckc commented May 15, 2018

Can you suggest how we might make a link to vote on an issue?

Err... navigate to it and bookmark the URL in your browser as usual. Is there some trick to this that I'm missing?

e.g. all votes on 668 in CSV, a vote related to 668 in HTML, vote exported in XML

Is all data from August 2017 onwards in the App?

Sorting the rewards by date shows that it's not, right? Again, is there a trick to this that I'm missing?

It's not clear to me how much you tried to find the answer yourself before putting the ball in my court. How to Ask Questions The Smart Way is largely common sense, but evidently it bears repeating:

When you ask your question, display the fact that you have [tried various ways to find the answer] first; this will help establish that you're not being a lazy sponge and wasting people's time.

@lapin7
Copy link
Contributor

lapin7 commented May 15, 2018

Here's a Budgets and Bounties spreadsheet to play with.

It has all data from August 2017 to April 2018

It's the base for a nice financial report.

@dckc
Copy link
Contributor

dckc commented May 15, 2018

data dump: http://rewards.rchain.coop/db-bak/201804.sql.gz

@dckc
Copy link
Contributor

dckc commented May 17, 2018

code to sync labels is committed and deployed:

The Right Thing would have been a new issue_label table to relate labels to issues; but I took a short-cut by just adding labels to the issue table.

Still to do: train guides.

@aviationhacker
Copy link

Just an update from Jim & myself, we've cloned the open issues table/site we built (https://rchain-bounty.glitch.me), and are now updating it with a GraphQL element and a MySQL element, looking to connect the two to basically add more functions in the future. The original site (https://rhobot.glitch.me) has been left as is, as we understand some people are using it to help them with other tasks.

At this point, if anyone is pretty good with GraphQL and feels like coaching us a little, we could definitely use the help!

@jimscarver
Copy link
Contributor

Anyone who knows some javascript or is willing to learn GraphQL and not too afraid of typing commands should join our collaborative learning work studies Thursday 2pm EST, Mon, Tue, Thu 4pm EST in https://zoom.us/j/6853551826

I expect the rhobot project will fork from this issue once the label review app is complete.

@dckc
Copy link
Contributor

dckc commented May 18, 2018

I looked into glitch a little... pretty cool!

I know javascript and GraphQL, but I'm not available at those times. I'm available Saturdays at 9am (#403).

@dckc
Copy link
Contributor

dckc commented May 23, 2018

@lapin7 thanks for the suggestion. How does it look?

  • 088f643 include labels in reward, budget views

@dckc
Copy link
Contributor

dckc commented May 23, 2018

I have talked with several guides about this: @lapin7 , @TrenchFloat , @pmoorman , @jimscarver .

Optimistically, I'm going to say that's a critical mass and they'll train the rest.

@dckc dckc closed this as completed May 23, 2018
@jimscarver
Copy link
Contributor

Prototyping support for the review process is continuing @dckc Is there someplace else to report that oe should this issue be reopened?
We added creation date and column sorting per member request to http://rhobot.glitch.me
Cookies to remember choices, more cross links to rewards and cosmetic improvement are in the pipe.

@dckc
Copy link
Contributor

dckc commented May 24, 2018

I wonder how to integrate rhobot.glitch.me into rewards.rchain.coop

But I suppose it's good to keep the discussion here for a bit...

@dckc dckc reopened this May 24, 2018
@jimscarver
Copy link
Contributor

jimscarver commented May 29, 2018

The answer is you don't integrate rhobot.glitch.me into rewards.rchain.coop. rhobot is a user driven self-sovereign interface independent of the rewards.rchain.coop interface. It integrates via APIs. We can integrate our own front ends using mysql but it would be nice if APIs for each function were available, preferably with GraphQL

Todaty Allanc, JIm, Gary and Aadi Reordered columns, added ALL to label dropdown
Added get issue by number and css in https://rhobot.glitch.me/

@dckc
Copy link
Contributor

dckc commented Jun 1, 2018

The answer is you don't integrate rhobot.glitch.me into rewards.rchain.coop.

Ok... then since this issue is about rewards.rchain.coop, that work is out of scope of this issue. Let's use #609 to track it.

@dckc
Copy link
Contributor

dckc commented Jun 7, 2018

@jimscarver @aviationhacker given the scope clarification above, your budget votes on this issue look a bit high. Please review.

@aviationhacker
Copy link

I've just had a look at my budget for this issue, but I can't see one that I've placed? Was it removed? If so, it saves me changing it :)

@dckc
Copy link
Contributor

dckc commented Jun 7, 2018

I guess I'm confusing you with @entropee .

@pmoorman
Copy link

pmoorman commented Sep 6, 2018

@dckc not sure if this is the right place (but it's better than nothing):

small feature request for the rewards app: Could we add the label "discussion" to the labels that would exclude an issue from the Overdue list?

Discussion issues often don't require a vote. #775 and #831 are examples of that nature (and sit in our marketing overdue list)

@dckc
Copy link
Contributor

dckc commented Sep 6, 2018

good idea

@dckc dckc reopened this Sep 6, 2018
@dckc
Copy link
Contributor

dckc commented Oct 5, 2018

I made the Discussion tweak 2018-09-26 in 121343ca

@dckc dckc closed this as completed Oct 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development splitting into core-dev, developer-education, ...? (guides: @dckc, ...) zz-Operations NEEDS SPONSOR guides: @TrenchFloat, @jimscarver @Tonyprisca13
Projects
None yet
Development

No branches or pull requests

5 participants