Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise log filtering for revealed events and bounty ID #914

Open
4 tasks
SkandaBhat opened this issue Sep 1, 2022 · 4 comments
Open
4 tasks

Optimise log filtering for revealed events and bounty ID #914

SkandaBhat opened this issue Sep 1, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@SkandaBhat
Copy link
Contributor

SkandaBhat commented Sep 1, 2022

  • Create an issue on github asking the accuracy of bloom filter
  • fetch data based on filter (index) in log query
  • fetch events from indexed epoch
  • For revealed data, verify duplicates.
@SkandaBhat
Copy link
Contributor Author

@SamAg19 can you please add how we can fetch these data from contracts?

@SkandaBhat SkandaBhat changed the title Do not use log bloom for Reveal data and bounty ID Optimise log filtering for revealed events and bounty ID Sep 2, 2022
@SkandaBhat SkandaBhat added the enhancement New feature or request label Sep 5, 2022
@SkandaBhat SkandaBhat assigned Yashk767 and unassigned ashish10677 Sep 13, 2022
@SkandaBhat SkandaBhat added this to the v1.0.1 milestone Sep 13, 2022
@Yashk767
Copy link
Contributor

fetch events from indexed epoch

  • Fetching revealData -
    In contracts v1, epoch is not indexed in reveal event, only stakerId is indexed.
    So logs should be filtered based on stakerId. Will implement this.

  • Fetching bountyId -
    We get bountyId from slashed event logs and we already do log filtering based on indexed bounty hunter.
    It is already implemented, so no change here.

@ashish10677 @SkandaBhat

@Yashk767
Copy link
Contributor

Yashk767 commented Sep 16, 2022

fetch events from indexed epoch

  • Fetching revealData -
    In contracts v1, epoch is not indexed in reveal event, only stakerId is indexed.
    So logs should be filtered based on stakerId. Will implement this.
  • Fetching bountyId -
    We get bountyId from slashed event logs and we already do log filtering based on indexed bounty hunter.
    It is already implemented, so no change here.

@ashish10677 @SkandaBhat

From the reveal event logs, we need to fetch all the revealed values and the respective influences for a epoch.
To perform this we don't need stakerId , we only need epoch, right?
On contracts stakerId is indexed, epoch is not.

I don't think we can filter reveal logs here.

@SkandaBhat @ashish10677

@SkandaBhat
Copy link
Contributor Author

This will be implemented in v2, since support for indexed epochs is available only for v2 contracts. cc: @hrishikeshio @Yashk767 @SamAg19

@Yashk767 Yashk767 modified the milestones: v1.0.1, v2 Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants