Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #9

Open
20 of 26 tasks
BlackDark opened this issue Apr 26, 2024 · 6 comments
Open
20 of 26 tasks

Feedback #9

BlackDark opened this issue Apr 26, 2024 · 6 comments

Comments

@BlackDark
Copy link
Contributor

BlackDark commented Apr 26, 2024

Feel free to provide feedback in this issue or feature requests.
Or just create a new issue for now :)

Possible ideas:

  • keep support for syncing trash guides
    • I like the possible configuration in recyclarr but I miss some features
  • add support for local configuration to include
    • I don't want to fork a project to add custom things to it
  • Maybe an free GUI to sync your stuff
  • Add additional best configuration for different languages/countries like Germany
  • Define CustomFormats directly in configuration maybe something like (directly translated JSON -> YAML?)
    Not sure if useful if we already have to capability to provide own formats via JSON folder (additional those JSON are directly compatible with UI Import)
    customFormats:
    - name: NewCF
      score: 125
      includeCustomFormatWhenRenaming: false
      specifications:
      - name: Size
        implementation: SizeSpecification
        negate: false
        required: true
        fields:
          min: 1
          max: 9

Work TODOs

@BlackDark BlackDark pinned this issue Apr 26, 2024
@raldone01
Copy link

"trash_scores": {
    "default": -10000
  },

I added custom format json files.
They get imported fine but the default score seems to be ignored.

custom_formats:
      # WEB-1080p
      # Optional
      - trash_ids:
          # custom german dl
          - custom-german-mic-dub # Avoid German Mic Dub
          - custom-german-dl      # Boost German DL
          - custom-german-dl-2    # Boost German DL
          - custom-english-only   # English+German > English Only > German Only
        quality_profiles:
          - name: WEB-1080p

I provided default scores in each but they all get added with score 0.

@BlackDark
Copy link
Contributor Author

BlackDark commented May 23, 2024

Sorry for the late response. Some questions:

  • the CF itself got created?
  • anything in the logs?
  • if everything looks create maybe you can create an example with the example structure to verify the not working part as fork

Here are my tests (Radarr instance):

# The CF
{
  "trash_id": "test-cf",
  "trash_scores": {
    "default": -10000
  },
  "name": "TEST CF",
  "includeCustomFormatWhenRenaming": false,
  "specifications": [
    {
      "name": "Size",
      "implementation": "SizeSpecification",
      "negate": true,
      "required": false,
      "fields": {
        "min": 0,
        "max": 100
      }
    }
  ]
}

# in the config or template
...
    custom_formats:
      - trash_ids:
          - test-cf
        quality_profiles:
          - name: Default (DE)
...

image

@raldone01
Copy link

raldone01 commented May 23, 2024

I will create a stripped down example when I get the time. (The formats were create correctly.) I will also try to include quality profiles as it did not seem to sync the order correctly.

@muhmuhhum
Copy link

would be nice to have support for other arr stack apps like readarr, whisparr

@BlackDark
Copy link
Contributor Author

would be nice to have support for other arr stack apps like readarr, whisparr

Hi @muhmuhhum have added #102 and #103 and will take a look. If the API is the same implementation should be straight forward. Downside is, that no default configurations/templates are provided by trash guide so everything has to be done by users themself.

@noelpilled
Copy link

noelpilled commented Jan 2, 2025

couple of feature requests:

  1. Support setting the root folder(s)
  2. Support setting indexer(s)
  3. Support setting download client(s)
  4. Support setting import lists, for syncing 2 instances of radarr/sonarr together
  5. A way to delete any quality profiles and maybe even custom formats which aren't being synced, should be opt-in

My root folders & indexers/download clients are always the same every time i set up the *arr stack, so it would be nice to just drop these into configarr's config and just not have to touch it again... the qp/cf thing is just annoying to me lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants