Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature idea: allow quality definition per block of IDs #29

Open
BlackDark opened this issue May 30, 2024 · 0 comments
Open

Feature idea: allow quality definition per block of IDs #29

BlackDark opened this issue May 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@BlackDark
Copy link
Contributor

Maybe it would make sense to make the quality definition also configurable per "block" of trash ids.

For example maybe something like this:

      - trash_ids:
        - 496f355514737f7d83bf7aa4d24f8169 # TrueHD Atmos
        - 2f22d89048b01681dde8afe203bf2e95 # DTS X
        - 417804f7f2c4308c1f4c5d380d4c4475 # ATMOS (undefined)
        - 1af239278386be2919e1bcee0bde047e # DD+ ATMOS
        - 3cafb66171b47f226146a0770576870f # TrueHD
        - dcf3ec6938fa32445f590a4da84256cd # DTS-HD MA
        - a570d4a0e56a2874b64e5bfa55202a1b # FLAC
        - e7c2fcae07cbada050a0af3357491d7b # PCM
        - 8e109e50e0a0b83a5098b056e13bf6db # DTS-HD HRA
        - 185f1dd7264c4562b9022d963ac37424 # DD+
        - f9f847ac70a0af62ea4a08280b859636 # DTS-ES
        - 1c1a4c5e823891c75bc50380a6866f73 # DTS
        - 240770601cc226190c367ef59aba7463 # AAC
        - c2998bd0d90ed5621d8df281e839436e # DD
        quality_profiles:
          - name: Default (DE)
        	# New: Here we can define for given trash ids + QPs which default score set should apply
            score_set: sqp-1-1080p

What this implies:

  • recheck merge strategy for CFs and QPs
  • Overwrite chain of score_sets
  • What if someone would like to enforce one specific score_set for all CFs? maybe add an option on QP layer like:
quality_profiles:
  - name: SQP-1 (1080p)
    # This is the existing. Can be seen as default if not overwritten
    score_set: sqp-1-1080p
	# New: here we could say that overwrite is not allowed?
    enforce_score_set: true
@BlackDark BlackDark added the enhancement New feature or request label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant