Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quality_definition handling differs from recyclarr handeling #128

Closed
thob97 opened this issue Dec 26, 2024 · 3 comments · Fixed by #139
Closed

quality_definition handling differs from recyclarr handeling #128

thob97 opened this issue Dec 26, 2024 · 3 comments · Fixed by #139
Assignees
@BlackDark

Comments

@thob97
Copy link

thob97 commented Dec 26, 2024

First of all, I want to express my gratitude for this amazing app. I was able to carry over almost all the settings from my existing Recyclarr setup and continue working seamlessly. I especially love that I can now define my own custom formats in addition to the Trash Guides.

Now, onto my issue. I have the following in my config.yml file:

    quality_definition:
      type: anime
      preferred_ratio: 1

When I use Recyclarr, the qualities are adjusted according to the Trash Guides (link).

However, Configarr doesn’t seem to touch the qualities at all. Unfortunately, nothing changes in the quality settings for Sonarr.

Additionally:
Would it be possible to add an option to not only follow the Trash Guide but also set and define custom quality settings?

Sonarr Version: 4.0.11.2680
Configarr Version: latest
@BlackDark BlackDark self-assigned this Dec 28, 2024
@BlackDark BlackDark mentioned this issue Jan 2, 2025
Merged
@BlackDark
Copy link
Contributor

Hi @thob97,

good catch found a bug where the setting does not get applied from the config.yml and only from included templates. Fixing that and creating a new issue for the other feature request.

Regarding the values from TRaSH does are not 1:1 what he defines in the provided json files (see here: https://github.com/TRaSH-Guides/Guides/blob/master/docs/json/radarr/quality-size/movie.json) but the min size should be correct.

@BlackDark BlackDark mentioned this issue Jan 2, 2025
Open
@BlackDark
Copy link
Contributor

@thob97 can you try this image if it fixes your problem: ghcr.io/raydak-labs/configarr:main@sha256:749842f037dbdff5ef8a36604f739d3e2e540a91ccc1bf0248ad4c159c68c113 if yes i will trigger a new release

@thob97
Copy link
Author

thob97 commented Jan 2, 2025

Thank you so much! It's partially working for me now.
The qualities are being adjusted according to the Trash Guides, which is great.

However, the preferred_ratio setting doesn't seem to be functioning as expected.
Whenever I change the value to 0 or 1, the Preferred value doesn't update at all.

Expected Behavior:
If I set preferred_ratio: 0, the Preferred value should be updated to the min value.

Here’s the relevant section from my config.yml file:

Radarr

    quality_definition:
      type: movie
      preferred_ratio: 0.1

Sonarr

    quality_definition:
      type: anime
      preferred_ratio: 0.1

And also the configarr.log

configarr  | INFO  [14:48:47.697]: Checking Recyclarr repo ...
configarr  | INFO  [14:48:48.127]: Recyclarr repo: ref[master], hash[79e91361094254d854280f5e81de0e7a56f76567], path[/app/repos/recyclarr-config]
configarr  | INFO  [14:48:48.128]: Checking TRaSH-Guides repo ...
configarr  | INFO  [14:48:48.518]: TRaSH-Guides repo: ref[master], hash[f26dd43f9d1949be43090c2a74d2e2bc5aab1705], path[/app/repos/trash-guides]
configarr  | INFO  [14:48:48.518]: 
configarr  | INFO  [14:48:48.519]: #############################################
configarr  | INFO  [14:48:48.520]: ### Processing Sonarr ...
configarr  | INFO  [14:48:48.520]: #############################################
configarr  | INFO  [14:48:48.520]: 
configarr  | INFO  [14:48:48.521]: Processing Sonarr Instance: series
configarr  | INFO  [14:48:48.672]: CustomFormats on server: 71
configarr  | INFO  [14:48:48.677]: Created CFs: 0, Updated CFs: 0, Untouched CFs: 71, Error CFs: 0
configarr  | INFO  [14:48:48.677]: CustomFormats synchronized
configarr  | { quality: 'SDTV', min: 5, preferred: 995, max: 1000 } 203 0.1
configarr  | { quality: 'WEBRip-480p', min: 5, preferred: 995, max: 1000 } 203 0.1
configarr  | { quality: 'WEBDL-480p', min: 5, preferred: 995, max: 1000 } 203 0.1
configarr  | { quality: 'DVD', min: 5, preferred: 995, max: 1000 } 203 0.1
configarr  | { quality: 'Bluray-480p', min: 5, preferred: 995, max: 1000 } 203 0.1
configarr  | { quality: 'Bluray-576p', min: 5, preferred: 995, max: 1000 } 203 0.1
configarr  | { quality: 'HDTV-720p', min: 5, preferred: 995, max: 1000 } 203 0.1
configarr  | { quality: 'HDTV-1080p', min: 5, preferred: 995, max: 1000 } 203 0.1
configarr  | { quality: 'WEBRip-720p', min: 5, preferred: 995, max: 1000 } 203 0.1
configarr  | { quality: 'WEBDL-720p', min: 5, preferred: 995, max: 1000 } 203 0.1
configarr  | { quality: 'Bluray-720p', min: 5, preferred: 995, max: 1000 } 203 0.1
configarr  | { quality: 'WEBRip-1080p', min: 5, preferred: 995, max: 1000 } 203 0.1
configarr  | { quality: 'WEBDL-1080p', min: 5, preferred: 995, max: 1000 } 203 0.1
configarr  | { quality: 'Bluray-1080p', min: 5, preferred: 995, max: 1000 } 203 0.1
configarr  | { quality: 'Bluray-1080p Remux', min: 5, preferred: 995, max: 1000 } 203 0.1
configarr  | { quality: 'HDTV-2160p', min: 5, preferred: 995, max: 1000 } 203 0.1
configarr  | { quality: 'WEBRip-2160p', min: 5, preferred: 995, max: 1000 } 203 0.1
configarr  | { quality: 'WEBDL-2160p', min: 5, preferred: 995, max: 1000 } 203 0.1
configarr  | { quality: 'Bluray-2160p', min: 5, preferred: 995, max: 1000 } 203 0.1
configarr  | { quality: 'Bluray-2160p Remux', min: 5, preferred: 995, max: 1000 } 203 0.1
configarr  | INFO  [14:48:48.694]: Diffs in quality definitions found
configarr  | INFO  [14:48:48.723]: Updated QualityDefinitions
configarr  | INFO  [14:48:48.740]: QualityProfiles: Create: 0, Update: 3, Unchanged: 0
configarr  | INFO  [14:48:48.929]: Updated QualityProfile: recyclarr_default_english
configarr  | INFO  [14:48:48.967]: Updated QualityProfile: recyclarr_default_german
configarr  | INFO  [14:48:48.989]: Updated QualityProfile: recyclarr_anime_sub
configarr  | INFO  [14:48:48.989]: 
configarr  | INFO  [14:48:48.989]: #############################################
configarr  | INFO  [14:48:48.990]: ### Processing Radarr ...
configarr  | INFO  [14:48:48.990]: #############################################
configarr  | INFO  [14:48:48.990]: 
configarr  | INFO  [14:48:48.990]: Processing Radarr Instance: movies
configarr  | INFO  [14:48:49.117]: CustomFormats on server: 76
configarr  | INFO  [14:48:49.120]: Created CFs: 0, Updated CFs: 0, Untouched CFs: 76, Error CFs: 0
configarr  | INFO  [14:48:49.120]: CustomFormats synchronized
configarr  | { quality: 'HDTV-720p', min: 17.1, preferred: 1999, max: 2000 } 413.4800000000001 0.1
configarr  | { quality: 'WEBDL-720p', min: 12.5, preferred: 1999, max: 2000 } 409.8 0.1
configarr  | { quality: 'WEBRip-720p', min: 12.5, preferred: 1999, max: 2000 } 409.8 0.1
configarr  | { quality: 'Bluray-720p', min: 25.7, preferred: 1999, max: 2000 } 420.36 0.1
configarr  | { quality: 'HDTV-1080p', min: 33.8, preferred: 1999, max: 2000 } 426.84000000000003 0.1
configarr  | { quality: 'WEBDL-1080p', min: 12.5, preferred: 1999, max: 2000 } 409.8 0.1
configarr  | { quality: 'WEBRip-1080p', min: 12.5, preferred: 1999, max: 2000 } 409.8 0.1
configarr  | { quality: 'Bluray-1080p', min: 50.8, preferred: 1999, max: 2000 } 440.44000000000005 0.1
configarr  | { quality: 'Remux-1080p', min: 102, preferred: 1999, max: 2000 } 481.40000000000003 0.1
configarr  | { quality: 'HDTV-2160p', min: 85, preferred: 1999, max: 2000 } 467.8 0.1
configarr  | { quality: 'WEBDL-2160p', min: 34.5, preferred: 1999, max: 2000 } 427.40000000000003 0.1
configarr  | { quality: 'WEBRip-2160p', min: 34.5, preferred: 1999, max: 2000 } 427.40000000000003 0.1
configarr  | { quality: 'Bluray-2160p', min: 102, preferred: 1999, max: 2000 } 481.40000000000003 0.1
configarr  | { quality: 'Remux-2160p', min: 187.4, preferred: 1999, max: 2000 } 549.72 0.1
configarr  | INFO  [14:48:49.126]: Diffs in quality definitions found
configarr  | INFO  [14:48:49.471]: Updated QualityDefinitions
configarr  | INFO  [14:48:49.485]: QualityProfiles: Create: 0, Update: 3, Unchanged: 0
configarr  | INFO  [14:48:49.520]: Updated QualityProfile: recyclarr_default_english
configarr  | INFO  [14:48:49.553]: Updated QualityProfile: recyclarr_default_german
configarr  | INFO  [14:48:49.582]: Updated QualityProfile: recyclarr_anime_sub
configarr  | INFO  [14:48:49.582]: 
configarr  | INFO  [14:48:49.583]: #############################################
configarr  | INFO  [14:48:49.583]: ### No Whisparr instances defined.
configarr  | INFO  [14:48:49.583]: #############################################
configarr  | INFO  [14:48:49.583]: 
configarr  | INFO  [14:48:49.583]: 
configarr  | INFO  [14:48:49.583]: #############################################
configarr  | INFO  [14:48:49.584]: ### No Readarr instances defined.
configarr  | INFO  [14:48:49.584]: #############################################
configarr  | INFO  [14:48:49.584]: 
configarr exited with code 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BlackDark BlackDark

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use quality_defintion from main config if defined raydak-labs/configarr
2 participants
@BlackDark @thob97