Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tagName property is always undefined #16

Open
blackmambahk opened this issue Oct 27, 2017 · 0 comments
Open

tagName property is always undefined #16

blackmambahk opened this issue Oct 27, 2017 · 0 comments

Comments

@blackmambahk
Copy link

blackmambahk commented Oct 27, 2017 •
edited
Loading

there is a problem with parse.js line 67:

byTag[current.tagName] = current;

current.tagName is always undefined.

In parse-tag.js line 33 the property 'name' is set not tagName as referenced above:
res.name = match;

I think it should be 'tagName' as 'name' can conflict with an attribute 'name' in an Input tag for example..

Also 'byTag' seems to be unused so could be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blackmambahk