Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Raise ValueError when the data sort key is None #48969

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[Data] Raise ValueError when the data sort key is None #48969

wants to merge 3 commits into from

Conversation

Superskyyy
Copy link
Contributor

@Superskyyy Superskyyy commented Nov 27, 2024 •
edited
Loading

Why are these changes needed?

Closes: #48926 #48927

Related issue number

Checks

  • [x ] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Superskyyy Superskyyy mentioned this pull request Nov 27, 2024
Open
@Superskyyy Superskyyy changed the title Raise ValueError when the data sort key is None [Data] Raise ValueError when the data sort key is None Nov 27, 2024
@Superskyyy
Remove test file
a648a35 
Signed-off-by: Superskyyy <[email protected]>
@richardliaw richardliaw self-assigned this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@bveeramani bveeramani Awaiting requested review from bveeramani bveeramani is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@omatthew98 omatthew98 Awaiting requested review from omatthew98 omatthew98 is a code owner

@alexeykudinkin alexeykudinkin Awaiting requested review from alexeykudinkin alexeykudinkin is a code owner

@srinathk10 srinathk10 Awaiting requested review from srinathk10 srinathk10 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@richardliaw richardliaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data] Default value of key in sort(key=None) raises IndexError
2 participants
@Superskyyy @richardliaw