Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Util] Better tracing for serializability errors #48759

Open
Oblynx opened this issue Nov 15, 2024 · 1 comment
Open

[Util] Better tracing for serializability errors #48759

Oblynx opened this issue Nov 15, 2024 · 1 comment
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability P1 Issue that should be fixed within a few weeks

Comments

@Oblynx
Copy link

Oblynx commented Nov 15, 2024

Description

In inspect_serializability, when reporting that something isn't serializable, we could in some cases give more info as to the location of the offending object. For example, in _inspect_func_serialization, we could add a log line like this:

f"In {parent.__name__}:{base_obj}:"

This would help a lot in localizing the issues.

Use case

I'm trying to effectively use already existing code as .map steps in Ray Data. The already existing code is likely to be non-serializable.

@Oblynx Oblynx added enhancement Request for new feature and/or capability triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Nov 15, 2024
@jcotant1 jcotant1 added the core Issues that should be addressed in Ray Core label Nov 17, 2024
@Superskyyy
Copy link
Contributor

Failures: {FailTuple(lock [obj=<unlocked _thread.lock object at 0x7fa1b4f8fa00>, parent=<function test at 0x7fa1b4f88c20>])} It does already output such info, is there anyting missing?

@jjyao jjyao added P1 Issue that should be fixed within a few weeks and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

No branches or pull requests

4 participants