Skip to content

Commit

Permalink
Appease the linter some more
Browse files Browse the repository at this point in the history
Signed-off-by: Richo Healey <[email protected]>
  • Loading branch information
richo-anyscale committed Nov 19, 2024
1 parent 7ea3b10 commit b82d2f9
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
5 changes: 2 additions & 3 deletions python/ray/dashboard/modules/job/tests/test_job_agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
self._session.headers[
"User-Agent"
] = "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36"
] = "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36" # noqa: E501


@pytest_asyncio.fixture
Expand Down Expand Up @@ -294,7 +294,6 @@ async def test_submit_job_rejects_browsers(
# wheel into the conda spec, it links to the current Python site.
monkeypatch.setenv("RAY_RUNTIME_ENV_LOCAL_DEV_MODE", "1")

# Instead of using the fixtured client, we stand up a similar version which uses a browser UA. We still grab the other one because it vblocks on the underlying agent starting up
agent_client, head_client = job_sdk_client
agent_address = agent_client._agent_address
agent_client = JobAgentSubmissionBrowserClient(agent_address)
Expand All @@ -309,7 +308,7 @@ async def test_submit_job_rejects_browsers(
)

with pytest.raises(RuntimeError) as exc:
submit_result = await agent_client.submit_job_internal(request)
_ = await agent_client.submit_job_internal(request)

assert "status code 405" in str(exc.value)

Expand Down
2 changes: 1 addition & 1 deletion python/ray/dashboard/optional_deps.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from aiohttp import hdrs # noqa: F401
from aiohttp.typedefs import PathLike # noqa: F401
from aiohttp.web import RouteDef # noqa: F401
from aiohttp.web import Request
from aiohttp.web import Request # noqa: F401

# Adding new modules should also be reflected in the
# python/ray/tests/test_minimal_install.py
3 changes: 2 additions & 1 deletion python/ray/util/state/custom_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ def validate_protobuf_enum(grpc_enum, custom_enum):
if len(enum_vals) > 0:
assert enum_vals == set(
custom_enum
), "Literals and protos out of sync, consider building //:install_py_proto with bazel?"
), """Literals and protos out of sync,\
consider building //:install_py_proto with bazel?"""


# Do the enum validation here.
Expand Down

0 comments on commit b82d2f9

Please sign in to comment.