Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session store should only update expiry unless changed param is true #271

Open
plaliberte opened this issue Feb 13, 2019 · 0 comments
Open
Assignees
Milestone

Comments

@plaliberte
Copy link

The session store currently performs a full set when a session object is unchanged. If the object is not changed we should only update the expiry rather than reposting the entire session object.

This will help avoid issues with the following case:

  1. Start long running request
  2. Destroy session in a separate request
  3. Long running request finishes

With a full post of the session the long running request will put the session back in the store effectively cancelling out the session destroy.

@plaliberte plaliberte self-assigned this Feb 13, 2019
@Ghnuberath Ghnuberath added this to the Release 1.0.0 milestone Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants