You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, each authentication mechanism must have a completely separate implementation, which also makes it difficult to track down issues if something goes wrong during authentication, as Ravel itself doesn't know about it. Most auth providers follow the same approach:
We should be able to implement all of this functionality internally, and have the authentication provider expose portions that can be overridden when required. If the redirect functionality is not 100% across all providers, Ravel can also leverage passport's custom callbacks instead of mandating redirects (we'll have to figure out how to give the function the proper context - req/res/..., as required):
I think it makes sense to leave AuthenticationProvider as-is, but to extend it to another abstract superclass which encompasses this functionality. That way AuthenticationProvider creators can extend either as they see fit.
Right now, each authentication mechanism must have a completely separate implementation, which also makes it difficult to track down issues if something goes wrong during authentication, as Ravel itself doesn't know about it. Most auth providers follow the same approach:
We should be able to implement all of this functionality internally, and have the authentication provider expose portions that can be overridden when required. If the redirect functionality is not 100% across all providers, Ravel can also leverage passport's custom callbacks instead of mandating redirects (we'll have to figure out how to give the function the proper context - req/res/..., as required):
The text was updated successfully, but these errors were encountered: