Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rc library. Use internal implementation instead. #171

Closed
Ghnuberath opened this issue Nov 22, 2016 · 1 comment
Closed

Remove rc library. Use internal implementation instead. #171

Ghnuberath opened this issue Nov 22, 2016 · 1 comment
Assignees
@Ghnuberath
Labels
refactor semver-patch
Milestone
Release 1.0.0

Comments

@Ghnuberath
Copy link
Member

Ghnuberath commented Nov 22, 2016 •
edited
Loading

Rationale:

  • rc now does way more than we want it to, including parsing command-line args and environment variables
  • rc still hasn't merged Adds support for #82's conclusion. dominictarr/rc#85. It's been 7 months since I opened the corresponding issue
  • always nice to remove dependencies
@Ghnuberath Ghnuberath added this to the Release 1.0.0 milestone Nov 22, 2016
@Ghnuberath Ghnuberath self-assigned this Nov 22, 2016
@Ghnuberath Ghnuberath changed the title Remove rc library. Use internal require instead. Remove rc library. Use internal implementation instead. Nov 22, 2016
@Ghnuberath Ghnuberath mentioned this issue Nov 22, 2016
Merged
@Ghnuberath
Copy link
Member Author

Fixed by #172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ghnuberath Ghnuberath

Labels
refactor semver-patch
Projects
None yet
Milestone
Release 1.0.0
Development

No branches or pull requests
1 participant
@Ghnuberath